From: Greg KH <greg@kroah.com>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH] Clear sparse warning: different address space
Date: Wed, 29 Mar 2017 09:33:20 +0200 [thread overview]
Message-ID: <20170329073320.GD8459@kroah.com> (raw)
In-Reply-To: <20170325030503.31675-1-kedrot@gmail.com>
On Sat, Mar 25, 2017 at 12:05:03AM -0300, Guillermo O. Freschi wrote:
> Made tagged `index` as `__user` to remove warning from
> `obd_iocontrol` call.
Your subject line is odd, please make it match other changes for this
driver.
> Signed-off-by: Guillermo O. Freschi <kedrot@gmail.com>
> ---
> drivers/staging/lustre/lustre/llite/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c
> index 13b35922a4ca..acdde21d41d9 100644
> --- a/drivers/staging/lustre/lustre/llite/dir.c
> +++ b/drivers/staging/lustre/lustre/llite/dir.c
> @@ -1464,7 +1464,7 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> case LL_IOC_FID2MDTIDX: {
> struct obd_export *exp = ll_i2mdexp(inode);
> struct lu_fid fid;
> - __u32 index;
> + __u32 __user index;
Are you sure? How did you test this?
thanks,
greg k-h
parent reply other threads:[~2017-03-29 7:33 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170325030503.31675-1-kedrot@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329073320.GD8459@kroah.com \
--to=greg@kroah.com \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.