All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Tejun Heo <tj@kernel.org>
Cc: John Garry <john.garry@huawei.com>,
	Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2] libsas: fix "sysfs group not found" warnings at port teardown time
Date: Wed, 29 Mar 2017 10:11:42 +0200	[thread overview]
Message-ID: <20170329081142.GA3794@linux-x5ow.site> (raw)
In-Reply-To: <20170328214149.GE28157@htj.duckdns.org>

On Tue, Mar 28, 2017 at 05:41:49PM -0400, Tejun Heo wrote:
> > But as I said, I don't belive this is a problem in the SAS transport or the
> > SAS drivers, but a device core or transport class.
> 
> So, what's most likely happening is that the parent device or kobject
> which contains the attribute group has already been removed earlier
> and because the removal is recursive, the later explicit removal is
> trying to remove already removed files.  It can be fixed either by
> reordering so that the parent node is removed after the children or
> simply dropping the explicit removal of children.

Hi Tejun,

Thanks for haivng a look at this. I already did this earlier and it didn't have
an effect at all. But I forgot to flush the SAS desctruct workqueue so it didn't
have an effect.

Thanks for re-pointing me to it. Patches fixing the issue are coming finally :-).

Byte,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

      reply	other threads:[~2017-03-29  8:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 23:00 [PATCH v2] libsas: fix "sysfs group not found" warnings at port teardown time Dan Williams
2015-05-21  7:54 ` Luis Henriques
2015-05-21  7:54   ` Luis Henriques
2017-03-19 12:44 ` Johannes Thumshirn
2017-03-19 12:44   ` Johannes Thumshirn
     [not found]   ` <b98e90a0-4914-0277-4aca-03a897b59ac0@huawei.com>
     [not found]     ` <20170321135154.GF30013@linux-x5ow.site>
     [not found]       ` <5f350965-017b-fd5b-8fad-eba01682d72e@huawei.com>
     [not found]         ` <20170324112347.GE3571@linux-x5ow.site>
     [not found]           ` <8415e37f-4d96-4b92-a967-cf41a4291e8f@huawei.com>
2017-03-24 16:53             ` Johannes Thumshirn
2017-03-28 21:41               ` Tejun Heo
2017-03-29  8:11                 ` Johannes Thumshirn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170329081142.GA3794@linux-x5ow.site \
    --to=jthumshirn@suse.de \
    --cc=john.garry@huawei.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.