From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2] drm/i915/dp: Validate cached link rate and lane count before retraining Date: Wed, 29 Mar 2017 14:46:04 +0300 Message-ID: <20170329114604.GW30290@intel.com> References: <1490651090-4263-1-git-send-email-manasi.d.navare@intel.com> <20170328155539.GC6506@intel.com> <87r31g5ynf.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 429D1893D0 for ; Wed, 29 Mar 2017 11:46:08 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87r31g5ynf.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMjksIDIwMTcgYXQgMTA6Mjk6MjRBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAyOCBNYXIgMjAxNywgTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJl QGludGVsLmNvbT4gd3JvdGU6Cj4gPiBKYW5pLAo+ID4KPiA+IFNob3VsZCBJIGp1c3QgaG9sZCBv biB0byB0aGlzIHVudGlsIHlvdXIgcGF0Y2ggc2VyaWVzCj4gPiBnZXRzIG1lcmdlZCBzbyBJIGNh biByZWJhc2UgdGhpcyBvbiB0b3Agb2YgaXQ/Cj4gCj4gSSB0aGluayBJJ2QgcHJlZmVyIHRoYXQs IGVzcGVjaWFsbHkgc28gYmVjYXVzZSBJJ20gbm90IHN1cmUgdGhhdCB0aGlzCj4gcGF0Y2ggZG9l cyB0aGUgcmlnaHQgdGhpbmcuIFllcywgdGhpcyBjaGVja3MgdGhhdCB0aGUgdmFsdWVzIGFyZSB3 aXRoaW4KPiBib3VuZHMsIGJ1dCB0aGF0IHRoZXkgYXJlIHdpdGhpbiBib3VuZHMgZG9lc24ndCBt YWtlIHRoZW0gYW55IG1vcmUgdmFsaWQKPiBmb3IgdGhlIGN1cnJlbnQgbGluayBpZiB0aGV5IGFy ZSBpbmRlZWQgc3RhbGUhCgpDYW4gdGhleSBiZSBzdGFsZSBhbmQgc3RpbGwgYmUgd2l0aGluIHRo ZSBib3VuZHMgc29tZWhvdz8gVGhhdCBkb2Vzbid0Cm1ha2UgbXVjaCBzZW5zZSB0byBtZS4gQWx0 aG9naCB0aGUgd2F5IHdlIHNocmluayB0aGUgc2V0IG9mIHZhbGlkIHBhcmFtcwpkb2Vzbid0IG1h a2UgbXVjaCBzZW5zZSB0byBtZSBlaXRoZXIgc2luY2Ugd2UgZG9uJ3QgbW9ub3RvbmljYWxseSBy ZWR1Y2UKdGhlIGxpbmsgYncuCgo+IAo+IEJSLAo+IEphbmkuCj4gCj4gCj4gPgo+ID4gUmVnYXJk cwo+ID4gTWFuYXNpCj4gPgo+ID4KPiA+IE9uIE1vbiwgTWFyIDI3LCAyMDE3IGF0IDAyOjQ0OjUw UE0gLTA3MDAsIE1hbmFzaSBOYXZhcmUgd3JvdGU6Cj4gPj4gQ3VycmVudGx5IGludGVsX2RwX2No ZWNrX2xpbmtfc3RhdHVzKCkgdHJpZXMgdG8gcmV0cmFpbiB0aGUgbGluayBpZgo+ID4+IENsb2Nr IHJlY292ZXJ5IG9yIENoYW5uZWwgRVEgZm9yIGFueSBvZiB0aGUgbGFuZXMgaW5kaWNhdGVkIGJ5 Cj4gPj4gaW50ZWxfZHAtPmxhbmVfY291bnQgaXMgbm90IHNldC4gSG93ZXZlciB0aGVzZSB2YWx1 ZXMgY2FjaGVkIGluIGludGVsX2RwCj4gPj4gc3RydWN0dXJlIGNhbiBiZSBzdGFsZSBpZiBsaW5r IHRyYWluaW5nIGhhcyBmYWlsZWQgZm9yIHRoZXNlIHZhbHVlcwo+ID4+IGR1cmluZyBwcmV2aW91 cyBtb2Rlc2V0LiBPciB0aGVzZSB2YWx1ZXMgY2FuIGdldCBzdGFsZSBzaW5jZSB3ZSBoYXZlCj4g Pj4gbm93IHJlIHJlYWQgdGhlIERQQ0QgcmVnaXN0ZXJzIG9yIGl0IGNhbiBiZSAwIGluIGNhc2Ug b2YgY29ubmVjdGVkIGJvb3QKPiA+PiBjYXNlLgo+ID4+IAo+ID4+IFRoaXMgcGF0Y2ggdmFsaWRh dGVzIHRoZXNlIHZhbHVlcyBhZ2FpbnN0IHRoZSBjb21tb25fcmF0ZXMgYW5kIG1heCBsYW5lCj4g Pj4gY291bnQgdmFsdWVzLgo+ID4+IAo+ID4+IFRoaXMgaXMgYWJzb2x1dGVseSByZXF1aXJlZCBp bmNhc2UgdGhlIGNvbW1vbl9yYXRlcyBvciBtYXggbGFuZSBjb3VudAo+ID4+IGFyZSBub3cgZGlm ZmVyZW50IGR1ZSB0byBsaW5rIGZhbGxiYWNrLgo+ID4+IAo+ID4+IHYyOgo+ID4+ICogSW5jbHVk ZSB0aGUgRklYTUUgY29tbW5ldCBpbnNpZGUgdGhlIGZ1bmN0aW9uIChWaWxsZSBTeXJqYWxhKQo+ ID4+ICogUmVtb3ZlIHRoZSByZWR1bmRhbnQgcGFyZW50aGVzaXMgKFZpbGxlIFN5cmphbGEpCj4g Pj4gCj4gPj4gQ2M6IFZpbGxlIFN5cmphbGEgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+ID4+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXguaW50ZWwuY29tPgo+ID4+ IFNpZ25lZC1vZmYtYnk6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+ Cj4gPj4gLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCAyOCArKysr KysrKysrKysrKysrKysrKysrKysrLS0tCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRp b25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4+IAo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ ID4+IGluZGV4IGZkOTZhNmMuLmQwYWIzMDcgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RwLmMKPiA+PiBAQCAtMjk1LDYgKzI5NSwyNyBAQCBzdGF0aWMgaW50IGludGVsX2RwX2xpbmtf cmF0ZV9pbmRleChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ID4+ICAJcmV0dXJuIC0xOwo+ ID4+ICB9Cj4gPj4gIAo+ID4+ICtzdGF0aWMgYm9vbCBpbnRlbF9kcF9saW5rX3BhcmFtc19pc192 YWxpZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ID4+ICt7Cj4gPj4gKwlpbnQgY29tbW9u X3JhdGVzW0RQX01BWF9TVVBQT1JURURfUkFURVNdOwo+ID4+ICsJaW50IGxpbmtfcmF0ZV9pbmRl eDsKPiA+PiArCj4gPj4gKwkvKiBGSVhNRTogd2UgbmVlZCB0byBzeW5jaHJvbml6ZSB0aGUgY3Vy cmVudCBsaW5rIHBhcmFtZXRlcnMgd2l0aAo+ID4+ICsJICogaGFyZHdhcmUgcmVhZG91dC4gQ3Vy cmVudGx5IGZhc3QgbGluayB0cmFpbmluZyBkb2Vzbid0IHdvcmsKPiA+PiArCSAqIG9uIGJvb3Qt dXAuCj4gPj4gKwkgKi8KPiA+PiArCWxpbmtfcmF0ZV9pbmRleCA9IGludGVsX2RwX2xpbmtfcmF0 ZV9pbmRleChpbnRlbF9kcCwKPiA+PiArCQkJCQkJICAgY29tbW9uX3JhdGVzLAo+ID4+ICsJCQkJ CQkgICBpbnRlbF9kcC0+bGlua19yYXRlKTsKPiA+PiArCWlmIChsaW5rX3JhdGVfaW5kZXggPCAw KQo+ID4+ICsJCXJldHVybiBmYWxzZTsKPiA+PiArCWlmICghaW50ZWxfZHAtPmxhbmVfY291bnQg fHwKPiA+PiArCSAgICBpbnRlbF9kcC0+bGFuZV9jb3VudCA+IGludGVsX2RwX21heF9sYW5lX2Nv dW50KGludGVsX2RwKSkKPiA+PiArCQlyZXR1cm4gZmFsc2U7Cj4gPj4gKwo+ID4+ICsJcmV0dXJu IHRydWU7Cj4gPj4gK30KPiA+PiArCj4gPj4gIGludCBpbnRlbF9kcF9nZXRfbGlua190cmFpbl9m YWxsYmFja192YWx1ZXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiA+PiAgCQkJCQkgICAg aW50IGxpbmtfcmF0ZSwgdWludDhfdCBsYW5lX2NvdW50KQo+ID4+ICB7Cj4gPj4gQEAgLTQyMjQs OSArNDI0NSwxMCBAQCBpbnRlbF9kcF9jaGVja19saW5rX3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAg KmludGVsX2RwKQo+ID4+ICAJaWYgKCF0b19pbnRlbF9jcnRjKGludGVsX2VuY29kZXItPmJhc2Uu Y3J0YyktPmFjdGl2ZSkKPiA+PiAgCQlyZXR1cm47Cj4gPj4gIAo+ID4+IC0JLyogRklYTUU6IHdl IG5lZWQgdG8gc3luY2hyb25pemUgdGhpcyBzb3J0IG9mIHN0dWZmIHdpdGggaGFyZHdhcmUKPiA+ PiAtCSAqIHJlYWRvdXQuIEN1cnJlbnRseSBmYXN0IGxpbmsgdHJhaW5pbmcgZG9lc24ndCB3b3Jr IG9uIGJvb3QtdXAuICovCj4gPj4gLQlpZiAoIWludGVsX2RwLT5sYW5lX2NvdW50KQo+ID4+ICsJ LyogVmFsaWRhdGUgdGhlIGNhY2hlZCB2YWx1ZXMgb2YgaW50ZWxfZHAtPmxpbmtfcmF0ZSBhbmQK PiA+PiArCSAqIGludGVsX2RwLT5sYW5lX2NvdW50IGJlZm9yZSBhdHRlbXB0aW5nIHRvIHJldHJh aW4uCj4gPj4gKwkgKi8KPiA+PiArCWlmICghaW50ZWxfZHBfbGlua19wYXJhbXNfaXNfdmFsaWQo aW50ZWxfZHApKQo+ID4+ICAJCXJldHVybjsKPiA+PiAgCj4gPj4gIAkvKiBSZXRyYWluIGlmIENo YW5uZWwgRVEgb3IgQ1Igbm90IG9rICovCj4gPj4gLS0gCj4gPj4gMi4xLjQKPiA+PiAKPiAKPiAt LSAKPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=