From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Wed, 29 Mar 2017 14:57:48 +0200 Subject: [PATCH net-next v2] net: mvneta: set rx mode during resume if interface is running In-Reply-To: <20170329084719.3596-1-jszhang@marvell.com> References: <20170329084719.3596-1-jszhang@marvell.com> Message-ID: <20170329125748.GD28922@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Mar 29, 2017 at 04:47:19PM +0800, Jisheng Zhang wrote: > I found a bug by: > > 0. boot and start dhcp client > 1. echo mem > /sys/power/state > 2. resume back immediately > 3. don't touch dhcp client to renew the lease > 4. ping the gateway. No acks > > Usually, after step2, the DHCP lease isn't expired, so in theory we > should resume all back. But in fact, it doesn't. It turns out > the rx mode isn't resumed correctly. This patch fixes it by adding > mvneta_set_rx_mode(dev) in the resume hook if interface is running. > > Signed-off-by: Jisheng Zhang Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932831AbdC2M5x (ORCPT ); Wed, 29 Mar 2017 08:57:53 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:39235 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932353AbdC2M5v (ORCPT ); Wed, 29 Mar 2017 08:57:51 -0400 Date: Wed, 29 Mar 2017 14:57:48 +0200 From: Andrew Lunn To: Jisheng Zhang Cc: thomas.petazzoni@free-electrons.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v2] net: mvneta: set rx mode during resume if interface is running Message-ID: <20170329125748.GD28922@lunn.ch> References: <20170329084719.3596-1-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170329084719.3596-1-jszhang@marvell.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 29, 2017 at 04:47:19PM +0800, Jisheng Zhang wrote: > I found a bug by: > > 0. boot and start dhcp client > 1. echo mem > /sys/power/state > 2. resume back immediately > 3. don't touch dhcp client to renew the lease > 4. ping the gateway. No acks > > Usually, after step2, the DHCP lease isn't expired, so in theory we > should resume all back. But in fact, it doesn't. It turns out > the rx mode isn't resumed correctly. This patch fixes it by adding > mvneta_set_rx_mode(dev) in the resume hook if interface is running. > > Signed-off-by: Jisheng Zhang Reviewed-by: Andrew Lunn Andrew