From: Tony Lindgren <tony@atomide.com>
To: Liam Breck <liam@networkimprov.net>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Liam Breck <kernel@networkimprov.net>
Subject: Re: [PATCH v2] power: bq24190_charger: Uniform pm_runtime_get() failure handling
Date: Wed, 29 Mar 2017 09:30:25 -0700 [thread overview]
Message-ID: <20170329163025.GO8575@atomide.com> (raw)
In-Reply-To: <20170329014913.3970-1-liam@networkimprov.net>
* Liam Breck <liam@networkimprov.net> [170328 18:52]:
> From: Liam Breck <kernel@networkimprov.net>
>
> On pm_runtime_get() failure, always emit an error message.
> Prevent unbalanced pm_runtime_get by calling:
> pm_runtime_put_noidle() in irq handler
> pm_runtime_put_sync() on any probe() failure
> Rename probe() out labels instead of renumbering them.
>
> Fixes: 13d6fa8447fa power: bq24190_charger: Use PM runtime autosuspend
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Liam Breck <kernel@networkimprov.net>
> ---
> v2: not rebased to Hans' extcon patch, which needs some work.
Looks OK to me:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2017-03-29 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 1:49 [PATCH v2] power: bq24190_charger: Uniform pm_runtime_get() failure handling Liam Breck
2017-03-29 16:30 ` Tony Lindgren [this message]
2017-03-29 18:01 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329163025.GO8575@atomide.com \
--to=tony@atomide.com \
--cc=hdegoede@redhat.com \
--cc=kernel@networkimprov.net \
--cc=liam@networkimprov.net \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.