From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 1/3] block: warn if sharing request queue across gendisks
Date: Wed, 29 Mar 2017 10:06:08 -0700 [thread overview]
Message-ID: <20170329170608.GA19015@vader> (raw)
In-Reply-To: <20170329141035.GB8461@kernel.dk>
On Wed, Mar 29, 2017 at 08:10:35AM -0600, Jens Axboe wrote:
> On Tue, Mar 28 2017, Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@fb.com>
> >
> > Now that the remaining drivers have been converted to one request queue
> > per gendisk, let's warn if a request queue gets registered more than
> > once. This will catch future drivers which might do it inadvertently or
> > any old drivers that I may have missed.
>
> Added 1-3 for 4.12, thanks. Final nail in the coffin for shared queues.
Thanks!
> BTW, can you include a cover letter when it's more than one patch? Makes
> the flow a bit more straight forward.
Yeah, I'll make sure to do that in the future.
prev parent reply other threads:[~2017-03-29 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 23:12 [PATCH v2 1/3] block: warn if sharing request queue across gendisks Omar Sandoval
2017-03-28 23:12 ` [PATCH v2 2/3] blk-mq: fix leak of q->stats Omar Sandoval
2017-03-28 23:12 ` [PATCH v2 3/3] block: fix leak of q->rq_wb Omar Sandoval
2017-03-29 14:10 ` [PATCH v2 1/3] block: warn if sharing request queue across gendisks Jens Axboe
2017-03-29 17:06 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329170608.GA19015@vader \
--to=osandov@osandov.com \
--cc=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.