From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [v5] package: add qt5virtualkeyboard
Date: Wed, 29 Mar 2017 18:00:16 +0200 [thread overview]
Message-ID: <20170329180016.12208367@free-electrons.com> (raw)
In-Reply-To: <20170329155822.32245-1-gael.portay@savoirfairelinux.com>
Hello,
On Wed, 29 Mar 2017 11:58:22 -0400, Ga?l PORTAY wrote:
> Changes since v4:
> - Prefix local variables to avoid potential naming collisions.
You forgot one.
> +QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS = $(call qstrip,$(BR2_PACKAGE_QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS))
> +QT5VIRTUALKEYBOARD_ALL_LAYOUTS = $(findstring all,$(QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS))
> +ifneq ($(strip $(QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS)),)
> +QMAKEFLAGS += CONFIG+="$(foreach lang,$(QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS),lang-$(lang))"
QMAKEFLAGS is still not properly prefixed.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-29 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 15:58 [Buildroot] [v5] package: add qt5virtualkeyboard Gaël PORTAY
2017-03-29 16:00 ` Thomas Petazzoni [this message]
2017-03-29 16:03 ` Gaël PORTAY
2017-03-29 16:03 ` Thomas Petazzoni
2017-03-29 17:29 ` Gaël PORTAY
2017-03-29 19:05 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329180016.12208367@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.