From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/1] nvme: don't ignore tagset allocation failures
Date: Wed, 29 Mar 2017 19:10:30 -0400 [thread overview]
Message-ID: <20170329231029.GE20181@localhost.localdomain> (raw)
In-Reply-To: <fb263c4e-0403-c39c-1c88-be47d846c2b6@grimberg.me>
On Wed, Mar 29, 2017@08:42:33PM +0300, Sagi Grimberg wrote:
>
> > Not having a tagset doesn't mean we can't go live; it just means we can't
> > do IO, but the admin handle is still up for device management.
>
> So don't queue ns scanning...
And what about the sysfs rescan or namespace notify async event? We have
to fence those off too, so doing it in one place sounds better than
three.
> > Also, nvme_queue_scan can be triggered from places outside nvme pci's control,
> > so I think Max's patch is an appropriate place to check.
>
> How is that not racy?
The tagset can only be allocated while the controller is not "LIVE", so
that satisfies synchronizing this resource.
next prev parent reply other threads:[~2017-03-29 23:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 9:03 [PATCH 1/1] nvme: don't ignore tagset allocation failures Max Gurtovoy
2017-03-29 17:19 ` Sagi Grimberg
2017-03-29 17:32 ` Keith Busch
2017-03-29 17:42 ` Sagi Grimberg
2017-03-29 23:10 ` Keith Busch [this message]
2017-03-30 5:47 ` Sagi Grimberg
2017-03-30 7:13 ` Max Gurtovoy
2017-03-30 13:05 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329231029.GE20181@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.