From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
qemu devel <qemu-devel@nongnu.org>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: Re: [Qemu-devel] issues of region cache and iommu reset
Date: Thu, 30 Mar 2017 00:31:53 +0300 [thread overview]
Message-ID: <20170330002953-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <bba32cde-6d38-3b49-3bb4-058a5d81d038@redhat.com>
On Wed, Mar 29, 2017 at 05:24:18PM +0800, Jason Wang wrote:
>
>
> On 2017年03月29日 17:11, Paolo Bonzini wrote:
> >
> > On 29/03/2017 11:09, Jason Wang wrote:
> > > > > This looks a good fix but may not solve this issue completely. Depends
> > > > > on the iova that guest uses, address_space_cache_init() may succeed even
> > > > > in this case since vtd does a passthrough translation in this case.
> > > > Can you explain this more?
> > > Yes. In this case, virtio-net-pci is not reset, but vtd has been reset.
> > > So virtio-net-pci will still try to use the iova of ring to setup the
> > > cache but now vtd treat iova as gpa since dmar has been disabled during
> > > reset. (E.g In my test with Linux driver, desc map succeed but used fail.)
> > That would be a Linux bug, the devices below the IOMMU have to be reset
> > first.
> >
> > Paolo
>
> Maybe, but I meet the same issue if I do a "system_reset". I think we should
> guarantee IOMMU was reset after any pci devices in this case too?
>
> Thanks
>
system reset would indeed appear to be a big issue.
--
MST
next prev parent reply other threads:[~2017-03-29 21:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 8:00 [Qemu-devel] issues of region cache and iommu reset Jason Wang
2017-03-29 8:09 ` Paolo Bonzini
2017-03-29 8:37 ` Jason Wang
2017-03-29 8:41 ` Paolo Bonzini
2017-03-29 9:09 ` Jason Wang
2017-03-29 9:11 ` Paolo Bonzini
2017-03-29 9:24 ` Jason Wang
2017-03-29 21:31 ` Michael S. Tsirkin [this message]
2017-03-29 8:45 ` Cornelia Huck
2017-03-29 9:18 ` Jason Wang
2017-03-29 11:39 ` Cornelia Huck
2017-03-30 2:14 ` Jason Wang
2017-03-29 21:28 ` Michael S. Tsirkin
2017-03-30 9:02 ` Paolo Bonzini
2017-03-29 8:16 ` Peter Xu
2017-03-29 21:38 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330002953-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.