From: Florian Westphal <fw@strlen.de>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: netfilter-devel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] iptables: extensions: Remove assignment in if condition.
Date: Thu, 30 Mar 2017 11:02:39 +0200 [thread overview]
Message-ID: <20170330090239.GD18679@breakpoint.cc> (raw)
In-Reply-To: <20170329233459.GA22682@arushi-HP-Pavilion-Notebook>
Arushi Singhal <arushisinghal19971997@gmail.com> wrote:
> Remove assignments in if condition as reported by checkpatch.pl.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> extensions/libebt_ip.c | 11 ++++++-----
> extensions/libip6t_ipv6header.c | 5 +++--
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/extensions/libebt_ip.c b/extensions/libebt_ip.c
> index 4ca63e9..deae6f4 100644
> --- a/extensions/libebt_ip.c
> +++ b/extensions/libebt_ip.c
> @@ -68,9 +68,9 @@ parse_port_range(const char *protocol, const char *portstring, uint16_t *ports)
> {
> char *buffer;
> char *cp;
> -
> + cp = strchr(buffer, ':');
This is broken.
prev parent reply other threads:[~2017-03-30 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 23:34 [PATCH] iptables: extensions: Remove assignment in if condition Arushi Singhal
2017-03-30 9:02 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330090239.GD18679@breakpoint.cc \
--to=fw@strlen.de \
--cc=arushisinghal19971997@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.