From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Dave Martin <Dave.Martin@arm.com>,
James Hogan <james.hogan@imgtec.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH 4.4 12/14] metag/ptrace: Reject partial NT_METAG_RPIPE writes
Date: Thu, 30 Mar 2017 11:58:46 +0200 [thread overview]
Message-ID: <20170330094946.990643620@linuxfoundation.org> (raw)
In-Reply-To: <20170330094944.906915050@linuxfoundation.org>
4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dave Martin <Dave.Martin@arm.com>
commit 7195ee3120d878259e8d94a5d9f808116f34d5ea upstream.
It's not clear what behaviour is sensible when doing partial write of
NT_METAG_RPIPE, so just don't bother.
This patch assumes that userspace will never rely on a partial SETREGSET
in this case, since it's not clear what should happen anyway.
Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Acked-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
arch/metag/kernel/ptrace.c | 2 ++
1 file changed, 2 insertions(+)
--- a/arch/metag/kernel/ptrace.c
+++ b/arch/metag/kernel/ptrace.c
@@ -253,6 +253,8 @@ int metag_rp_state_copyin(struct pt_regs
unsigned long long *ptr;
int ret, i;
+ if (count < 4*13)
+ return -EINVAL;
/* Read the entire pipeline before making any changes */
ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
&rp, 0, 4*13);
next prev parent reply other threads:[~2017-03-30 10:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 9:58 [PATCH 4.4 00/14] 4.4.59-stable review Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 01/14] xfrm: policy: init locks early Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 02/14] xfrm_user: validate XFRM_MSG_NEWAE XFRMA_REPLAY_ESN_VAL replay_window Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 03/14] xfrm_user: validate XFRM_MSG_NEWAE incoming ESN size harder Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 04/14] virtio_balloon: init 1st buffer in stats vq Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 05/14] pinctrl: qcom: Dont clear status bit on irq_unmask Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 06/14] c6x/ptrace: Remove useless PTRACE_SETREGSET implementation Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 07/14] h8300/ptrace: Fix incorrect register transfer count Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 08/14] mips/ptrace: Preserve previous registers for short regset write Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 09/14] sparc/ptrace: " Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 10/14] metag/ptrace: " Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 11/14] metag/ptrace: Provide default TXSTATUS for short NT_PRSTATUS Greg Kroah-Hartman
2017-03-30 9:58 ` Greg Kroah-Hartman [this message]
2017-03-30 9:58 ` [PATCH 4.4 13/14] fscrypt: remove broken support for detecting keyring key revocation Greg Kroah-Hartman
2017-03-30 9:58 ` [PATCH 4.4 14/14] sched/rt: Add a missing rescheduling point Greg Kroah-Hartman
2017-03-30 18:52 ` [PATCH 4.4 00/14] 4.4.59-stable review Shuah Khan
2017-03-31 3:45 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330094946.990643620@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=Dave.Martin@arm.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.