From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933262AbdC3Ayy (ORCPT ); Wed, 29 Mar 2017 20:54:54 -0400 Received: from mail.kernel.org ([198.145.29.136]:42840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754231AbdC3Ayx (ORCPT ); Wed, 29 Mar 2017 20:54:53 -0400 Date: Thu, 30 Mar 2017 09:54:42 +0900 From: Masami Hiramatsu To: Namhyung Kim Cc: Steven Rostedt , Ingo Molnar , Masami Hiramatsu , LKML , kernel-team@lge.com Subject: Re: [PATCH 0/4] ftrace: Add 'function-fork' trace option (v1) Message-Id: <20170330095442.c3d9ae668f6028cf81a7a7fd@kernel.org> In-Reply-To: <20170329014625.19346-1-namhyung@kernel.org> References: <20170329014625.19346-1-namhyung@kernel.org> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Mar 2017 10:46:21 +0900 Namhyung Kim wrote: > Hello, > > This patchset add 'function-fork' option to function tracer which > makes pid filter to be inherited like 'event-fork' does. During the > test, I found a bug of pid filter on an instance directory. The patch > 1 fixes it and maybe it should go to the stable tree. > > The function-fork option is disabled by default as event-fork does, > but we might consider changing the default since it seems to be more > natural from an user's perspective IMHO. By the way, I thought that event-fork option also effected to function tracer. Is there any reason we should separate those? I mean, we can add "trace-fork" option instead of "function-fork" for setting both pid filters at once. Thank you, > > The code is also available at 'ftrace/function-fork-v1' branch on > > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git > > Thanks, > Namhyung > > > Namhyung Kim (4): > ftrace: Fix function pid filter on instances > ftrace: Add 'function-fork' trace option > selftests: ftrace: Add -l/--logdir option > selftests: ftrace: Add a testcase for function PID filter > > kernel/trace/ftrace.c | 47 ++++++++++- > kernel/trace/trace.c | 6 +- > kernel/trace/trace.h | 8 +- > tools/testing/selftests/ftrace/ftracetest | 5 ++ > .../ftrace/test.d/ftrace/func-filter-pid.tc | 98 ++++++++++++++++++++++ > 5 files changed, 158 insertions(+), 6 deletions(-) > create mode 100644 tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc > > -- > 2.12.0 > -- Masami Hiramatsu