All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willy TARREAU <wtarreau@haproxy.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder
Date: Thu, 30 Mar 2017 14:54:42 +0200	[thread overview]
Message-ID: <20170330125442.GE793@haproxy.com> (raw)
In-Reply-To: <1490873226.708.68.camel@linux.intel.com>

On Thu, Mar 30, 2017 at 02:27:06PM +0300, Andy Shevchenko wrote:
> On Mon, 2017-03-27 at 11:01 +0200, Willy TARREAU wrote:
> > On Mon, Mar 27, 2017 at 10:26:07AM +0200, Geert Uytterhoeven wrote:
> > > On Mon, Mar 27, 2017 at 10:11 AM, Willy TARREAU <wtarreau@haproxy.co
> > > m> wrote:
> > > > On Fri, Mar 24, 2017 at 04:19:43PM +0100, Geert Uytterhoeven
> > > > wrote:
> > > > > On Fri, Mar 24, 2017 at 3:29 PM, Andy Shevchenko
> > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > On Fri, 2017-03-24 at 15:19 +0100, Geert Uytterhoeven wrote:
> > > > > > > On Fri, Mar 24, 2017 at 3:06 PM, Andy Shevchenko
> > > > > > > <andriy.shevchenko@linux.intel.com> wrote:
> 
> > In fact here the output signals should be seen as a shared bus with
> > multiple
> > chip select signals. Note that in some designs it's even possible that
> > pressing
> > multiple buttons will cause crap to be sent to the LCD by short-
> > circuiting
> > the lines (if no diodes are used) but it might be acceptable for many
> > designs,
> > especially the DIY field where the principle is "don't do it".
> 
> So, summarizing the comments are we okay to proceed or there is a clear
> objection?

I don't know all the impacts, but as long as it continues to work I'm
totally fine with seeing the code being changed and refactored. It
already got a nice improvement with this series. Furthermore I can
occasionally give it a try if that helps :-)

Willy

  reply	other threads:[~2017-03-30 12:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24 14:06 [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Andy Shevchenko
2017-03-24 14:06 ` [PATCH v1 2/2] auxdisplay: Move arm-charlcd.c " Andy Shevchenko
2017-03-24 15:16   ` Linus Walleij
2017-03-24 14:19 ` [PATCH v1 1/2] auxdisplay: Move panel.c " Geert Uytterhoeven
2017-03-24 14:29   ` Andy Shevchenko
2017-03-24 15:19     ` Geert Uytterhoeven
2017-03-27  8:11       ` Willy TARREAU
2017-03-27  8:26         ` Geert Uytterhoeven
2017-03-27  9:01           ` Willy TARREAU
2017-03-30 11:27             ` Andy Shevchenko
2017-03-30 12:54               ` Willy TARREAU [this message]
2017-04-04 16:27                 ` Andy Shevchenko
2017-03-27 14:12       ` Arnd Bergmann
2017-03-27 14:15         ` Geert Uytterhoeven
2017-03-30 11:39 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170330125442.GE793@haproxy.com \
    --to=wtarreau@haproxy.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.