From: Kalle Valo <kvalo@codeaurora.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless@vger.kernel.org,
Daniel J Blueman <daniel@quora.org>,
Arend van Spriel <arend.vanspriel@broadcom.com>
Subject: Re: [for-4.11, 1/2] brcmfmac: use local iftype avoiding use-after-free of virtual interface
Date: Thu, 30 Mar 2017 16:44:29 +0000 (UTC) [thread overview]
Message-ID: <20170330164429.CBF7060E0E@smtp.codeaurora.org> (raw)
In-Reply-To: <1490688691-20100-2-git-send-email-arend.vanspriel@broadcom.com>
Arend Van Spriel <arend.vanspriel@broadcom.com> wrote:
> A use-after-free was found using KASAN. In brcmf_p2p_del_if() the virtual
> interface is removed using call to brcmf_remove_interface(). After that
> the virtual interface instance has been freed and should not be referenced.
> Solve this by storing the nl80211 iftype in local variable, which is used
> in a couple of places anyway.
>
> Cc: stable@vger.kernel.org # 4.10.x, 4.9.x
> Reported-by: Daniel J Blueman <daniel@quora.org>
> Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
> Reviewed-by: Franky Lin <franky.lin@broadcom.com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-drivers.git, thanks.
d77facb88448 brcmfmac: use local iftype avoiding use-after-free of virtual interface
--
https://patchwork.kernel.org/patch/9648553/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-03-30 16:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 8:11 [PATCH for-4.11 0/2] brcmfmac: fixing use-after-free reports Arend van Spriel
2017-03-28 8:11 ` [PATCH for-4.11 1/2] brcmfmac: use local iftype avoiding use-after-free of virtual interface Arend van Spriel
2017-03-30 16:44 ` Kalle Valo [this message]
2017-03-28 8:11 ` [PATCH for-4.11 2/2] cfg80211: check rdev resume callback only for registered wiphy Arend van Spriel
2017-03-28 12:34 ` Johannes Berg
2017-03-28 14:13 ` Arend Van Spriel
2017-03-28 14:25 ` Johannes Berg
2017-03-28 14:46 ` Arend Van Spriel
2017-03-29 6:34 ` Johannes Berg
2017-03-29 7:13 ` Johannes Berg
2017-03-28 11:59 ` [PATCH for-4.11 0/2] brcmfmac: fixing use-after-free reports Kalle Valo
2017-03-28 14:08 ` Arend Van Spriel
2017-03-28 15:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330164429.CBF7060E0E@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=daniel@quora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.