From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Igor Mammedov" <imammedo@redhat.com>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH for-2.9 v2] tests/bios-tables-test: Don't pass addresses of packed struct fields
Date: Thu, 30 Mar 2017 18:13:13 +0300 [thread overview]
Message-ID: <20170330181243-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAFEAcA_VSavXRVr=z1kDuxUu6Jy3OG6DKQJ_xrify_OMT7TeEA@mail.gmail.com>
On Thu, Mar 30, 2017 at 04:08:59PM +0100, Peter Maydell wrote:
> On 28 March 2017 at 14:30, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> > should we add some comment like /* local variable used to avoid alignment
> > issues */ in case later one find it clever to save few bytes on stack
> > without reading git history?
>
> Hmm. There's no obvious single place where that could be put,
> and I tend to think that if you're going to use packed structures
> then "caution needed" is implicit. When we have these bug fixes
> in then the plan is to add sparc to the set of standard merge
> build tests, which will catch accidental reversions of this
> fix (and eventually clang 4 will be more widespread which will
> warn about this.)
>
> thanks
> -- PMM
Let's apply this for now but I really don't remember why did we
make it packed in the 1st place.
--
MST
next prev parent reply other threads:[~2017-03-30 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 9:40 [Qemu-devel] [PATCH for-2.9 v2] tests/bios-tables-test: Don't pass addresses of packed struct fields Peter Maydell
2017-03-28 13:14 ` Eric Blake
2017-03-28 13:30 ` Philippe Mathieu-Daudé
2017-03-30 15:08 ` Peter Maydell
2017-03-30 15:13 ` Michael S. Tsirkin [this message]
2017-03-30 15:11 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330181243-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.