From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Viktor Krasnov <vkrasnov@dev.rtsoft.ru>
Cc: Wolfram Sang <wsa@the-dreams.de>,
jdelvare@suse.com, linux-i2c@vger.kernel.org,
Edgar Cherkasov <echerkasov@dev.rtsoft.ru>,
Michael Brunner <Michael.Brunner@kontron.com>,
linux-acpi@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: [PATCH] i2c: i2c-scmi: add a MS HID
Date: Fri, 31 Mar 2017 10:47:22 +0300 [thread overview]
Message-ID: <20170331074722.GF2957@lahna.fi.intel.com> (raw)
In-Reply-To: <1490945467.3894.426.camel@vkrasnov.dev.rtsoft.ru>
On Fri, Mar 31, 2017 at 10:31:07AM +0300, Viktor Krasnov wrote:
> Hello Mika,
>
> thanks for the review.
>
> > > --- a/include/acpi/acpi_drivers.h
> > > +++ b/include/acpi/acpi_drivers.h
> > > @@ -60,6 +60,8 @@
> > > #define ACPI_DOCK_HID "LNXDOCK"
> > > /* Quirk for broken IBM BIOSes */
> > > #define ACPI_SMBUS_IBM_HID "SMBUSIBM"
> > > +/* SMBUS HID definition as supported by Microsoft Windows */
> > > +#define ACPI_SMBUS_MS_HID "SMB0001"
>
> > I agree with the reasoning but why do you add the ID here also? Wouldn't
> > it suffice if added only to the i2c-scmi.c driver?
>
> This has been done by analogy with existing ACPI_SMBUS_IBM_HID which is
> defined in acpi_drivers.h. I think that it may look confusing when some
> HIDs are defined in i2c-scmi.c and others - in acpi_drivers.h. Could you
> please clarify this moment and confirm that all HIDs must be defined
> only in i2c-scmi.c? I will rework the patch then.
If there is only one file using a HID, then I think it is fine to keep
it in the driver itself. If multiple files share the HID then it makes
sense to put it to include/acpi/acpi_drivers.h.
next prev parent reply other threads:[~2017-03-31 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 13:58 [PATCH] i2c: i2c-scmi: add a MS HID Viktor Krasnov
2017-03-23 20:47 ` Wolfram Sang
2017-03-30 15:52 ` Wolfram Sang
2017-03-31 7:20 ` Mika Westerberg
2017-03-31 7:31 ` Viktor Krasnov
2017-03-31 7:47 ` Mika Westerberg [this message]
2017-03-31 8:04 ` Viktor Krasnov
2017-03-31 10:01 ` Andy Shevchenko
2017-03-24 9:16 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331074722.GF2957@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Michael.Brunner@kontron.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=echerkasov@dev.rtsoft.ru \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=vkrasnov@dev.rtsoft.ru \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.