From mboxrd@z Thu Jan 1 00:00:00 1970 From: ville.syrjala@linux.intel.com (Ville =?iso-8859-1?Q?Syrj=E4l=E4?=) Date: Fri, 31 Mar 2017 13:11:23 +0300 Subject: [PATCH 3/3] drm/arm: hdlcd: check for rotation In-Reply-To: References: <20170331094937.GO7909@n2100.armlinux.org.uk> Message-ID: <20170331101123.GK30290@intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Mar 31, 2017 at 10:51:52AM +0100, Russell King wrote: > hdlcd does not support rotation - check for it and reject plane updates > that try to rotate a plane. > > Signed-off-by: Russell King > --- > drivers/gpu/drm/arm/hdlcd_crtc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c > index cf70184fd028..171acc842368 100644 > --- a/drivers/gpu/drm/arm/hdlcd_crtc.c > +++ b/drivers/gpu/drm/arm/hdlcd_crtc.c > @@ -215,6 +215,10 @@ static int hdlcd_plane_atomic_check(struct drm_plane *plane, > if (!crtc) > return 0; > > + /* We do not support rotation */ > + if (state->rotation != DRM_ROTATE_0) > + return -EINVAL; This can't happen unless you attach a rotation property with a bogus set of supported rotations to the plane. > + > crtc_state = drm_atomic_get_existing_crtc_state(state->state, crtc); > if (!crtc_state->enable) > return -EINVAL; > -- > 2.7.4 -- Ville Syrj?l? Intel OTC From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/3] drm/arm: hdlcd: check for rotation Date: Fri, 31 Mar 2017 13:11:23 +0300 Message-ID: <20170331101123.GK30290@intel.com> References: <20170331094937.GO7909@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C70736EA6D for ; Fri, 31 Mar 2017 10:11:30 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King Cc: Liviu Dudau , DRI devel , Mali DP Maintainers , LAKML List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXIgMzEsIDIwMTcgYXQgMTA6NTE6NTJBTSArMDEwMCwgUnVzc2VsbCBLaW5nIHdy b3RlOgo+IGhkbGNkIGRvZXMgbm90IHN1cHBvcnQgcm90YXRpb24gLSBjaGVjayBmb3IgaXQgYW5k IHJlamVjdCBwbGFuZSB1cGRhdGVzCj4gdGhhdCB0cnkgdG8gcm90YXRlIGEgcGxhbmUuCj4gCj4g U2lnbmVkLW9mZi1ieTogUnVzc2VsbCBLaW5nIDxybWsra2VybmVsQGFybWxpbnV4Lm9yZy51az4K PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FybS9oZGxjZF9jcnRjLmMgfCA0ICsrKysKPiAgMSBm aWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYXJtL2hkbGNkX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vaGRsY2RfY3J0Yy5j Cj4gaW5kZXggY2Y3MDE4NGZkMDI4Li4xNzFhY2M4NDIzNjggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2FybS9oZGxjZF9jcnRjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL2hk bGNkX2NydGMuYwo+IEBAIC0yMTUsNiArMjE1LDEwIEBAIHN0YXRpYyBpbnQgaGRsY2RfcGxhbmVf YXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAJaWYgKCFjcnRjKQo+ICAJ CXJldHVybiAwOwo+ICAKPiArCS8qIFdlIGRvIG5vdCBzdXBwb3J0IHJvdGF0aW9uICovCj4gKwlp ZiAoc3RhdGUtPnJvdGF0aW9uICE9IERSTV9ST1RBVEVfMCkKPiArCQlyZXR1cm4gLUVJTlZBTDsK ClRoaXMgY2FuJ3QgaGFwcGVuIHVubGVzcyB5b3UgYXR0YWNoIGEgcm90YXRpb24gcHJvcGVydHkg d2l0aCBhIGJvZ3VzCnNldCBvZiBzdXBwb3J0ZWQgcm90YXRpb25zIHRvIHRoZSBwbGFuZS4KCj4g Kwo+ICAJY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2NydGNfc3RhdGUoc3Rh dGUtPnN0YXRlLCBjcnRjKTsKPiAgCWlmICghY3J0Y19zdGF0ZS0+ZW5hYmxlKQo+ICAJCXJldHVy biAtRUlOVkFMOwo+IC0tIAo+IDIuNy40CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK