From: Greg KH <greg@kroah.com>
To: Chewie Lin <linsh@oregonstate.edu>
Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
Date: Fri, 31 Mar 2017 14:33:17 +0200 [thread overview]
Message-ID: <20170331123317.GA17717@kroah.com> (raw)
In-Reply-To: <20170331100112.8106-2-linsh@oregonstate.edu>
On Fri, Mar 31, 2017 at 03:01:12AM -0700, Chewie Lin wrote:
> fix a checkpatch warning:
> WARNING: Prefer using "%s", __func__ to embedded function names
>
> Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> ---
> drivers/staging/vt6656/main_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 9e074e9..2d9e7af 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
> status = usb_reset_device(priv->usb);
> if (status)
> dev_warn(&priv->usb->dev,
> - "usb_device_reset fail status=%d\n", status);
> + "%s=%d\n", "usb_device_reset fail status", status);
Your patch does not match your description at all :(
next prev parent reply other threads:[~2017-03-31 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 10:01 [PATCH] Eudyptula challenge Chewie Lin
2017-03-31 10:01 ` [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
2017-03-31 10:32 ` Kim Phillips
2017-03-31 12:33 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-04-17 23:58 [PATCH 0/1] " Chewie Lin
2017-04-17 23:58 ` [PATCH 1/1] " Chewie Lin
2017-04-18 4:14 ` Greg KH
2017-04-18 4:47 ` Chewie Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331123317.GA17717@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linsh@oregonstate.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.