From: Keith Busch <keith.busch@intel.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Josef Bacik <jbacik@fb.com>,
kernel-team@fb.com
Subject: Re: [PATCH v3] blk-mq: remap queues when adding/removing hardware queues
Date: Fri, 31 Mar 2017 17:09:00 -0400 [thread overview]
Message-ID: <20170331210900.GN20181@localhost.localdomain> (raw)
In-Reply-To: <9753ebd0c51a9d49f110a6d0d00888170905d97a.1490993257.git.osandov@fb.com>
On Fri, Mar 31, 2017 at 01:48:35PM -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> blk_mq_update_nr_hw_queues() used to remap hardware queues, which is the
> behavior that drivers expect. However, commit 4e68a011428a changed
> blk_mq_queue_reinit() to not remap queues for the case of CPU
> hotplugging, inadvertently making blk_mq_update_nr_hw_queues() not remap
> queues as well. This breaks, for example, NBD's multi-connection mode,
> leaving the added hardware queues unused. Fix it by making
> blk_mq_update_nr_hw_queues() explicitly remap the queues.
>
> Fixes: 4e68a011428a ("blk-mq: don't redistribute hardware queues on a CPU hotplug event")
> Signed-off-by: Omar Sandoval <osandov@fb.com>
This looks good to me.
Reviewed-by: Keith Busch <keith.busch@intel.com>
next prev parent reply other threads:[~2017-03-31 21:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 18:59 [PATCH] blk-mq: remap queues when adding/removing hardware queues Omar Sandoval
2017-03-31 19:01 ` Omar Sandoval
2017-03-31 20:30 ` Keith Busch
2017-03-31 20:30 ` Omar Sandoval
2017-03-31 20:44 ` Keith Busch
2017-03-31 20:43 ` [PATCH v2] " Omar Sandoval
2017-03-31 20:46 ` Omar Sandoval
2017-03-31 20:48 ` [PATCH v3] " Omar Sandoval
2017-03-31 21:09 ` Keith Busch [this message]
2017-04-04 6:24 ` Christoph Hellwig
2017-04-05 12:01 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331210900.GN20181@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.