From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v3 5/5] net/virtio-user: add lsc support
Date: Sat, 1 Apr 2017 13:13:40 +0800
Message-ID: <20170401051340.GO18844@yliu-dev.sh.intel.com>
References: <1488563803-87754-1-git-send-email-jianfeng.tan@intel.com>
 <1490989498-87546-1-git-send-email-jianfeng.tan@intel.com>
 <1490989498-87546-6-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, david.marchand@6wind.com, maxime.coquelin@redhat.com
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id A309EDE0
 for <dev@dpdk.org>; Sat,  1 Apr 2017 07:16:05 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1490989498-87546-6-git-send-email-jianfeng.tan@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Mar 31, 2017 at 07:44:58PM +0000, Jianfeng Tan wrote:
> +static void virtio_user_delayed_handler(void *param)

Coding style issue.

...
>  
>  	if (offset == offsetof(struct virtio_net_config, max_virtqueue_pairs))
>  		*(uint16_t *)dst = dev->max_queue_pairs;
> @@ -319,7 +362,11 @@ virtio_user_eth_dev_alloc(const char *name)
>  
>  	dev->portid = hw->port_id = data->port_id;
>  	virtio_hw_internal[hw->port_id].vtpci_ops = &virtio_user_ops;
> -	hw->use_msix = 0;
> +	/* After commit 26bbd3e7dc51("net/virtio: disable LSC interrupt if MSIX
> +	 * not enabled"), we require this to enable LSC. Just pretend that we
> +	 * support msix.
> +	 */

We normally do not reference a commit in comments. Instead, you could
simply say "this is required to enable LSC (see __the_function__), ...".

Series applied to dpdk-next-virtio, with above minor fixes.

	--yliu

> +	hw->use_msix = 1;
>  	hw->modern   = 0;
>  	hw->use_simple_rxtx = 0;
>  	hw->virtio_user_dev = dev;
> -- 
> 2.7.4