diff for duplicates of <20170401100936.57f45dd1@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 05f83cf..b1d3943 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,12 +1,12 @@ On Fri, 31 Mar 2017 20:21:11 +0200 -Andrew Lunn <andrew@lunn.ch> wrote: +Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> wrote: > On Fri, Mar 31, 2017 at 07:39:20PM +0200, Ralph Sennhauser wrote: > > On Fri, 31 Mar 2017 18:50:15 +0200 -> > Andrew Lunn <andrew@lunn.ch> wrote: +> > Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> wrote: > > -> > > > - sata at a8000 { -> > > > + satac0: sata at a8000 { +> > > > - sata@a8000 { +> > > > + satac0: sata@a8000 { > > > > > > Hi Ralph > > > @@ -35,17 +35,17 @@ meant as the example for the conflict I mentioned. That's another option I missed. $ git grep -n ahci.: - arch/arm/boot/dts/spear1310.dtsi:59: ahci0: ahci at b1000000 { - arch/arm/boot/dts/spear1310.dtsi:68: ahci1: ahci at b1800000 { - arch/arm/boot/dts/spear1310.dtsi:77: ahci2: ahci at b4000000 { - arch/arm/boot/dts/spear1340.dtsi:42: ahci0: ahci at b1000000 { + arch/arm/boot/dts/spear1310.dtsi:59: ahci0: ahci@b1000000 { + arch/arm/boot/dts/spear1310.dtsi:68: ahci1: ahci@b1800000 { + arch/arm/boot/dts/spear1310.dtsi:77: ahci2: ahci@b4000000 { + arch/arm/boot/dts/spear1340.dtsi:42: ahci0: ahci@b1000000 { Not a big list which I have here and the nodes themselves are named -ahci at xxxxxxxx. +ahci@xxxxxxxx. > -> > > > - usb3 at f0000 { -> > > > + usb3_0: usb3 at f0000 { +> > > > - usb3@f0000 { +> > > > + usb3_0: usb3@f0000 { > > > > compatible = > > > > "marvell,armada-380-xhci"; reg = <0xf0000 0x4000>,<0xf4000 > > > > 0x4000>; interrupts = <GIC_SPI 16 @@ -53,8 +53,8 @@ ahci at xxxxxxxx. > > > > status = "disabled"; > > > > }; > > > > -> > > > - usb3 at f8000 { -> > > > + usb3_1: usb3 at f8000 { +> > > > - usb3@f8000 { +> > > > + usb3_1: usb3@f8000 { > > > > compatible = > > > > "marvell,armada-380-xhci"; reg = <0xf8000 0x4000>,<0xfc000 > > > > 0x4000>; interrupts = <GIC_SPI 17 @@ -71,27 +71,27 @@ ahci at xxxxxxxx. > Humm... > > /* CON4 */ -> usb at 58000 { +> usb@58000 { > vcc-supply = <®_usb2_0_vbus>; > status = "okay"; > }; > > > /* CON5 */ -> usb3 at f0000 { +> usb3@f0000 { > usb-phy = <&usb2_1_phy>; > status = "okay"; > }; > > /* CON7 */ -> usb3 at f8000 { +> usb3@f8000 { > usb-phy = <&usb3_phy>; > status = "okay"; > }; > > Is this clear? Is CON5 a USB 3 host, but has a USB 2 PHY connected to > it? CON7 is the only true USB 3 port? I think some comments written in -> schwiizerd??tsch would be clearre.:-) +> schwiizerdütsch would be clearre.:-) Did you just find a bug? :) @@ -115,15 +115,15 @@ dts would actually have worked for both usb and sata labels :) Let's add another argument for and against usb3_x type labels: $ git grep -hn usb arch/arm/boot/dts/armada-38x.dtsi - 455: usb0: usb at 58000 { - 593: usb3_0: usb3 at f0000 { - 601: usb3_1: usb3 at f8000 { + 455: usb0: usb@58000 { + 593: usb3_0: usb3@f0000 { + 601: usb3_1: usb3@f8000 { They might actually be considered different types. usb vs. usb3, though that feels quite arbitrary. $ git grep -hn usb3_0 Documentation/devicetree/bindings/usb/qcom,dwc3.txt - 45: usb3_0: usb30 at 0 { + 45: usb3_0: usb30@0 { usb3_0 could be mistaken for the protocol version. A bit of a stretch as well ... @@ -142,3 +142,7 @@ happened here. Thanks Ralph +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index de80b7e..cb10751 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,21 +2,31 @@ "ref\020170331165015.GJ12814@lunn.ch\0" "ref\020170331193920.030d9ca8@gmail.com\0" "ref\020170331182111.GJ22609@lunn.ch\0" - "From\0ralph.sennhauser@gmail.com (Ralph Sennhauser)\0" - "Subject\0[PATCH] ARM: dts: armada-38x: label USB and SATA nodes\0" + "ref\020170331182111.GJ22609-g2DYL2Zd6BY@public.gmane.org\0" + "From\0Ralph Sennhauser <ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "Subject\0Re: [PATCH] ARM: dts: armada-38x: label USB and SATA nodes\0" "Date\0Sat, 1 Apr 2017 10:09:36 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>\0" + "Cc\0linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" + Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> + Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> + Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> + Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> + Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> + Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org> + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + " linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" "\00:1\0" "b\0" "On Fri, 31 Mar 2017 20:21:11 +0200\n" - "Andrew Lunn <andrew@lunn.ch> wrote:\n" + "Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> wrote:\n" "\n" "> On Fri, Mar 31, 2017 at 07:39:20PM +0200, Ralph Sennhauser wrote:\n" "> > On Fri, 31 Mar 2017 18:50:15 +0200\n" - "> > Andrew Lunn <andrew@lunn.ch> wrote:\n" + "> > Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> wrote:\n" "> > \n" - "> > > > -\t\t\tsata at a8000 {\n" - "> > > > +\t\t\tsatac0: sata at a8000 { \n" + "> > > > -\t\t\tsata@a8000 {\n" + "> > > > +\t\t\tsatac0: sata@a8000 { \n" "> > > \n" "> > > Hi Ralph\n" "> > > \n" @@ -45,17 +55,17 @@ "That's another option I missed.\n" "\n" " $ git grep -n ahci.:\n" - " arch/arm/boot/dts/spear1310.dtsi:59: ahci0: ahci at b1000000 {\n" - " arch/arm/boot/dts/spear1310.dtsi:68: ahci1: ahci at b1800000 {\n" - " arch/arm/boot/dts/spear1310.dtsi:77: ahci2: ahci at b4000000 {\n" - " arch/arm/boot/dts/spear1340.dtsi:42: ahci0: ahci at b1000000 {\n" + " arch/arm/boot/dts/spear1310.dtsi:59: ahci0: ahci@b1000000 {\n" + " arch/arm/boot/dts/spear1310.dtsi:68: ahci1: ahci@b1800000 {\n" + " arch/arm/boot/dts/spear1310.dtsi:77: ahci2: ahci@b4000000 {\n" + " arch/arm/boot/dts/spear1340.dtsi:42: ahci0: ahci@b1000000 {\n" "\n" "Not a big list which I have here and the nodes themselves are named\n" - "ahci at xxxxxxxx.\n" + "ahci@xxxxxxxx.\n" "\n" "> \n" - "> > > > -\t\t\tusb3 at f0000 {\n" - "> > > > +\t\t\tusb3_0: usb3 at f0000 {\n" + "> > > > -\t\t\tusb3@f0000 {\n" + "> > > > +\t\t\tusb3_0: usb3@f0000 {\n" "> > > > \t\t\t\tcompatible =\n" "> > > > \"marvell,armada-380-xhci\"; reg = <0xf0000 0x4000>,<0xf4000\n" "> > > > 0x4000>; interrupts = <GIC_SPI 16 \n" @@ -63,8 +73,8 @@ "> > > > \t\t\t\tstatus = \"disabled\";\n" "> > > > \t\t\t};\n" "> > > > \n" - "> > > > -\t\t\tusb3 at f8000 {\n" - "> > > > +\t\t\tusb3_1: usb3 at f8000 {\n" + "> > > > -\t\t\tusb3@f8000 {\n" + "> > > > +\t\t\tusb3_1: usb3@f8000 {\n" "> > > > \t\t\t\tcompatible =\n" "> > > > \"marvell,armada-380-xhci\"; reg = <0xf8000 0x4000>,<0xfc000\n" "> > > > 0x4000>; interrupts = <GIC_SPI 17 \n" @@ -81,27 +91,27 @@ "> Humm...\n" "> \n" "> /* CON4 */\n" - "> usb at 58000 {\n" + "> usb@58000 {\n" "> vcc-supply = <®_usb2_0_vbus>;\n" "> status = \"okay\";\n" "> };\n" "> \n" "> \n" "> \t\t\t/* CON5 */\n" - "> usb3 at f0000 {\n" + "> usb3@f0000 {\n" "> usb-phy = <&usb2_1_phy>;\n" "> status = \"okay\";\n" "> };\n" "> \n" "> /* CON7 */\n" - "> usb3 at f8000 {\n" + "> usb3@f8000 {\n" "> usb-phy = <&usb3_phy>;\n" "> status = \"okay\";\n" "> };\n" "> \n" "> Is this clear? Is CON5 a USB 3 host, but has a USB 2 PHY connected to\n" "> it? CON7 is the only true USB 3 port? I think some comments written in\n" - "> schwiizerd??tsch would be clearre.:-)\n" + "> schwiizerd\303\203\302\274tsch would be clearre.:-)\n" "\n" "Did you just find a bug? :)\n" "\n" @@ -125,15 +135,15 @@ "Let's add another argument for and against usb3_x type labels:\n" "\n" " $ git grep -hn usb arch/arm/boot/dts/armada-38x.dtsi\n" - " 455: usb0: usb at 58000 {\n" - " 593: usb3_0: usb3 at f0000 {\n" - " 601: usb3_1: usb3 at f8000 {\n" + " 455: usb0: usb@58000 {\n" + " 593: usb3_0: usb3@f0000 {\n" + " 601: usb3_1: usb3@f8000 {\n" "\n" "They might actually be considered different types. usb vs. usb3, though\n" "that feels quite arbitrary.\n" "\n" " $ git grep -hn usb3_0 Documentation/devicetree/bindings/usb/qcom,dwc3.txt\n" - " 45: usb3_0: usb30 at 0 {\n" + " 45: usb3_0: usb30@0 {\n" "\n" "usb3_0 could be mistaken for the protocol version. A bit of a stretch as well ...\n" "\n" @@ -151,6 +161,10 @@ "happened here.\n" "\n" "Thanks\n" - Ralph + "Ralph\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -a00bf3914995b8dcbe0135117b1e0c4be05e38b585b447c850ff4954092c52a1 +401dadc607d332d03d53156b34df123e202891d60d219cd4b95ab64980f5085d
diff --git a/a/1.txt b/N2/1.txt index 05f83cf..759f4df 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -5,8 +5,8 @@ Andrew Lunn <andrew@lunn.ch> wrote: > > On Fri, 31 Mar 2017 18:50:15 +0200 > > Andrew Lunn <andrew@lunn.ch> wrote: > > -> > > > - sata at a8000 { -> > > > + satac0: sata at a8000 { +> > > > - sata@a8000 { +> > > > + satac0: sata@a8000 { > > > > > > Hi Ralph > > > @@ -35,17 +35,17 @@ meant as the example for the conflict I mentioned. That's another option I missed. $ git grep -n ahci.: - arch/arm/boot/dts/spear1310.dtsi:59: ahci0: ahci at b1000000 { - arch/arm/boot/dts/spear1310.dtsi:68: ahci1: ahci at b1800000 { - arch/arm/boot/dts/spear1310.dtsi:77: ahci2: ahci at b4000000 { - arch/arm/boot/dts/spear1340.dtsi:42: ahci0: ahci at b1000000 { + arch/arm/boot/dts/spear1310.dtsi:59: ahci0: ahci@b1000000 { + arch/arm/boot/dts/spear1310.dtsi:68: ahci1: ahci@b1800000 { + arch/arm/boot/dts/spear1310.dtsi:77: ahci2: ahci@b4000000 { + arch/arm/boot/dts/spear1340.dtsi:42: ahci0: ahci@b1000000 { Not a big list which I have here and the nodes themselves are named -ahci at xxxxxxxx. +ahci@xxxxxxxx. > -> > > > - usb3 at f0000 { -> > > > + usb3_0: usb3 at f0000 { +> > > > - usb3@f0000 { +> > > > + usb3_0: usb3@f0000 { > > > > compatible = > > > > "marvell,armada-380-xhci"; reg = <0xf0000 0x4000>,<0xf4000 > > > > 0x4000>; interrupts = <GIC_SPI 16 @@ -53,8 +53,8 @@ ahci at xxxxxxxx. > > > > status = "disabled"; > > > > }; > > > > -> > > > - usb3 at f8000 { -> > > > + usb3_1: usb3 at f8000 { +> > > > - usb3@f8000 { +> > > > + usb3_1: usb3@f8000 { > > > > compatible = > > > > "marvell,armada-380-xhci"; reg = <0xf8000 0x4000>,<0xfc000 > > > > 0x4000>; interrupts = <GIC_SPI 17 @@ -71,27 +71,27 @@ ahci at xxxxxxxx. > Humm... > > /* CON4 */ -> usb at 58000 { +> usb@58000 { > vcc-supply = <®_usb2_0_vbus>; > status = "okay"; > }; > > > /* CON5 */ -> usb3 at f0000 { +> usb3@f0000 { > usb-phy = <&usb2_1_phy>; > status = "okay"; > }; > > /* CON7 */ -> usb3 at f8000 { +> usb3@f8000 { > usb-phy = <&usb3_phy>; > status = "okay"; > }; > > Is this clear? Is CON5 a USB 3 host, but has a USB 2 PHY connected to > it? CON7 is the only true USB 3 port? I think some comments written in -> schwiizerd??tsch would be clearre.:-) +> schwiizerdütsch would be clearre.:-) Did you just find a bug? :) @@ -115,15 +115,15 @@ dts would actually have worked for both usb and sata labels :) Let's add another argument for and against usb3_x type labels: $ git grep -hn usb arch/arm/boot/dts/armada-38x.dtsi - 455: usb0: usb at 58000 { - 593: usb3_0: usb3 at f0000 { - 601: usb3_1: usb3 at f8000 { + 455: usb0: usb@58000 { + 593: usb3_0: usb3@f0000 { + 601: usb3_1: usb3@f8000 { They might actually be considered different types. usb vs. usb3, though that feels quite arbitrary. $ git grep -hn usb3_0 Documentation/devicetree/bindings/usb/qcom,dwc3.txt - 45: usb3_0: usb30 at 0 { + 45: usb3_0: usb30@0 { usb3_0 could be mistaken for the protocol version. A bit of a stretch as well ... diff --git a/a/content_digest b/N2/content_digest index de80b7e..32a1603 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,10 +2,19 @@ "ref\020170331165015.GJ12814@lunn.ch\0" "ref\020170331193920.030d9ca8@gmail.com\0" "ref\020170331182111.GJ22609@lunn.ch\0" - "From\0ralph.sennhauser@gmail.com (Ralph Sennhauser)\0" - "Subject\0[PATCH] ARM: dts: armada-38x: label USB and SATA nodes\0" + "From\0Ralph Sennhauser <ralph.sennhauser@gmail.com>\0" + "Subject\0Re: [PATCH] ARM: dts: armada-38x: label USB and SATA nodes\0" "Date\0Sat, 1 Apr 2017 10:09:36 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Andrew Lunn <andrew@lunn.ch>\0" + "Cc\0linux-arm-kernel@lists.infradead.org" + Jason Cooper <jason@lakedaemon.net> + Gregory Clement <gregory.clement@free-electrons.com> + Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> + Rob Herring <robh+dt@kernel.org> + Mark Rutland <mark.rutland@arm.com> + Russell King <linux@armlinux.org.uk> + devicetree@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On Fri, 31 Mar 2017 20:21:11 +0200\n" @@ -15,8 +24,8 @@ "> > On Fri, 31 Mar 2017 18:50:15 +0200\n" "> > Andrew Lunn <andrew@lunn.ch> wrote:\n" "> > \n" - "> > > > -\t\t\tsata at a8000 {\n" - "> > > > +\t\t\tsatac0: sata at a8000 { \n" + "> > > > -\t\t\tsata@a8000 {\n" + "> > > > +\t\t\tsatac0: sata@a8000 { \n" "> > > \n" "> > > Hi Ralph\n" "> > > \n" @@ -45,17 +54,17 @@ "That's another option I missed.\n" "\n" " $ git grep -n ahci.:\n" - " arch/arm/boot/dts/spear1310.dtsi:59: ahci0: ahci at b1000000 {\n" - " arch/arm/boot/dts/spear1310.dtsi:68: ahci1: ahci at b1800000 {\n" - " arch/arm/boot/dts/spear1310.dtsi:77: ahci2: ahci at b4000000 {\n" - " arch/arm/boot/dts/spear1340.dtsi:42: ahci0: ahci at b1000000 {\n" + " arch/arm/boot/dts/spear1310.dtsi:59: ahci0: ahci@b1000000 {\n" + " arch/arm/boot/dts/spear1310.dtsi:68: ahci1: ahci@b1800000 {\n" + " arch/arm/boot/dts/spear1310.dtsi:77: ahci2: ahci@b4000000 {\n" + " arch/arm/boot/dts/spear1340.dtsi:42: ahci0: ahci@b1000000 {\n" "\n" "Not a big list which I have here and the nodes themselves are named\n" - "ahci at xxxxxxxx.\n" + "ahci@xxxxxxxx.\n" "\n" "> \n" - "> > > > -\t\t\tusb3 at f0000 {\n" - "> > > > +\t\t\tusb3_0: usb3 at f0000 {\n" + "> > > > -\t\t\tusb3@f0000 {\n" + "> > > > +\t\t\tusb3_0: usb3@f0000 {\n" "> > > > \t\t\t\tcompatible =\n" "> > > > \"marvell,armada-380-xhci\"; reg = <0xf0000 0x4000>,<0xf4000\n" "> > > > 0x4000>; interrupts = <GIC_SPI 16 \n" @@ -63,8 +72,8 @@ "> > > > \t\t\t\tstatus = \"disabled\";\n" "> > > > \t\t\t};\n" "> > > > \n" - "> > > > -\t\t\tusb3 at f8000 {\n" - "> > > > +\t\t\tusb3_1: usb3 at f8000 {\n" + "> > > > -\t\t\tusb3@f8000 {\n" + "> > > > +\t\t\tusb3_1: usb3@f8000 {\n" "> > > > \t\t\t\tcompatible =\n" "> > > > \"marvell,armada-380-xhci\"; reg = <0xf8000 0x4000>,<0xfc000\n" "> > > > 0x4000>; interrupts = <GIC_SPI 17 \n" @@ -81,27 +90,27 @@ "> Humm...\n" "> \n" "> /* CON4 */\n" - "> usb at 58000 {\n" + "> usb@58000 {\n" "> vcc-supply = <®_usb2_0_vbus>;\n" "> status = \"okay\";\n" "> };\n" "> \n" "> \n" "> \t\t\t/* CON5 */\n" - "> usb3 at f0000 {\n" + "> usb3@f0000 {\n" "> usb-phy = <&usb2_1_phy>;\n" "> status = \"okay\";\n" "> };\n" "> \n" "> /* CON7 */\n" - "> usb3 at f8000 {\n" + "> usb3@f8000 {\n" "> usb-phy = <&usb3_phy>;\n" "> status = \"okay\";\n" "> };\n" "> \n" "> Is this clear? Is CON5 a USB 3 host, but has a USB 2 PHY connected to\n" "> it? CON7 is the only true USB 3 port? I think some comments written in\n" - "> schwiizerd??tsch would be clearre.:-)\n" + "> schwiizerd\303\203\302\274tsch would be clearre.:-)\n" "\n" "Did you just find a bug? :)\n" "\n" @@ -125,15 +134,15 @@ "Let's add another argument for and against usb3_x type labels:\n" "\n" " $ git grep -hn usb arch/arm/boot/dts/armada-38x.dtsi\n" - " 455: usb0: usb at 58000 {\n" - " 593: usb3_0: usb3 at f0000 {\n" - " 601: usb3_1: usb3 at f8000 {\n" + " 455: usb0: usb@58000 {\n" + " 593: usb3_0: usb3@f0000 {\n" + " 601: usb3_1: usb3@f8000 {\n" "\n" "They might actually be considered different types. usb vs. usb3, though\n" "that feels quite arbitrary.\n" "\n" " $ git grep -hn usb3_0 Documentation/devicetree/bindings/usb/qcom,dwc3.txt\n" - " 45: usb3_0: usb30 at 0 {\n" + " 45: usb3_0: usb30@0 {\n" "\n" "usb3_0 could be mistaken for the protocol version. A bit of a stretch as well ...\n" "\n" @@ -153,4 +162,4 @@ "Thanks\n" Ralph -a00bf3914995b8dcbe0135117b1e0c4be05e38b585b447c850ff4954092c52a1 +cc298661fd0461bd63ada4d9636bfc9ab1e01b5af16515f46d28dd91af6faada
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.