From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Brian Foster <bfoster@redhat.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: move the inline directory verifiers
Date: Sun, 2 Apr 2017 09:17:43 +1000 [thread overview]
Message-ID: <20170401231743.GX23007@dastard> (raw)
In-Reply-To: <20170331164001.GA23577@infradead.org>
On Fri, Mar 31, 2017 at 09:40:01AM -0700, Christoph Hellwig wrote:
> On Fri, Mar 31, 2017 at 09:38:36AM -0700, Darrick J. Wong wrote:
> > On Fri, Mar 31, 2017 at 09:28:17AM -0700, Christoph Hellwig wrote:
> > > On Fri, Mar 31, 2017 at 09:24:31AM -0700, Darrick J. Wong wrote:
> > > > I think xfs/348 causes -rc4 to fall over if CONFIG_XFS_DEBUG=y due to
> > > > the XFS_WANT_CORRUPTED_RETURNs that shouldn't be there.
> > >
> > > Yes, that's the one. How are we going to fix that for -rc5?
> >
> > This patch fixes all the thinkos in the original patch, so I was just
> > going to send it to Linus for rc5, but decided to poll the ML to see if
> > anyone had an objection to that.
>
> That's what I thought and was surprised by the reply from Dave..
There's no mention that it fixes a bug, regression or anything else
like that in the commit message. AFAICT from the description, it's
just a cleanup to match how the rest of the checking code is
structured with better error reporting.
Perhaps the commit message needs more work, because I can't tell you
what bug this is fixing from it....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-04-01 23:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 23:03 [PATCH v2] xfs: move the inline directory verifiers Darrick J. Wong
2017-03-28 12:51 ` Brian Foster
2017-03-28 15:00 ` Darrick J. Wong
2017-03-28 15:11 ` Brian Foster
2017-03-28 17:24 ` Brian Foster
2017-03-29 18:21 ` Darrick J. Wong
2017-03-29 18:52 ` Brian Foster
2017-03-29 22:41 ` Dave Chinner
2017-03-31 16:07 ` Christoph Hellwig
2017-03-31 16:24 ` Darrick J. Wong
2017-03-31 16:28 ` Christoph Hellwig
2017-03-31 16:38 ` Darrick J. Wong
2017-03-31 16:40 ` Christoph Hellwig
2017-04-01 23:17 ` Dave Chinner [this message]
2017-03-31 17:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170401231743.GX23007@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.