From: Andreas Klinger <ak@it-klinger.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Matt Ranostay <matt.ranostay@intel.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
ddvlad@gmail.com, Akinobu Mita <akinobu.mita@gmail.com>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
Aniroop Mathur <a.mathur@samsung.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation
Date: Sun, 2 Apr 2017 19:29:49 +0200 [thread overview]
Message-ID: <20170402172949.GA1479@project> (raw)
In-Reply-To: <CACRpkdb06PcUwC_zRThLXcw=haiDzuqP-gsVjchNnSWkootT0Q@mail.gmail.com>
Linus Walleij <linus.walleij@linaro.org> schrieb am Sun, 02. Apr 16:56:
> On Sun, Apr 2, 2017 at 11:32 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> > On 27/03/17 11:06, Andreas Klinger wrote:
> >> While calculating the compensation of the humidity there are negative
> >> values interpreted as unsigned because of unsigned variables used.
> >> These values need to be casted to signed as indicated by the documentation
> >> of the sensor.
> >>
> >> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> >
> > Looks superficially right to me, but would like an Ack from Linus Walleij.
>
> I didn't work on these calculations, only infrastructure for the driver
> but FWIW:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Matt Ranostay @Intel is the person you probably want to ACK it though,
> he added the humidity calculations :)
It just turned out that there must be another error in the calculation. I'll fix
and test it first.
When i'm done i'll send a new version of the patch.
Andreas
>
> Yours,
> Linus Walleij
--
next prev parent reply other threads:[~2017-04-02 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 10:06 [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Andreas Klinger
2017-04-02 9:32 ` Jonathan Cameron
2017-04-02 14:56 ` Linus Walleij
2017-04-02 17:29 ` Andreas Klinger [this message]
2017-04-02 17:46 ` Jonathan Cameron
2017-04-04 6:16 ` Matt Ranostay
2017-04-07 6:13 ` Matt Ranostay
2017-04-07 19:27 ` Andreas Klinger
2017-04-08 21:34 ` Matt Ranostay
2017-04-10 16:47 ` Andreas Klinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170402172949.GA1479@project \
--to=ak@it-klinger.de \
--cc=a.mathur@samsung.com \
--cc=akinobu.mita@gmail.com \
--cc=ddvlad@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.ranostay@intel.com \
--cc=pmeerw@pmeerw.net \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.