From: "Daniel P. Berrange" <berrange@redhat.com>
To: Guang Wang <wang.guang55@zte.com.cn>
Cc: zhang.zhanghailiang@huawei.com, zhangchen.fnst@cn.fujitsu.com,
eblake@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] migration: Fix colo hang in socket_accept_incoming_migration
Date: Mon, 3 Apr 2017 12:04:35 +0100 [thread overview]
Message-ID: <20170403110435.GM2768@redhat.com> (raw)
In-Reply-To: <1490317489-3544-1-git-send-email-wang.guang55@zte.com.cn>
On Fri, Mar 24, 2017 at 09:04:49AM +0800, Guang Wang wrote:
> From: Wang guang <wang.guang55@zte.com.cn>
>
> The channel socket was initialized manually,
> but forgot to set QIO_CHANNEL_FEATURE_SHUTDOWN.
> Thus, the colo_process_incoming_thread would hang at recvmsg.
> This patch just call qio_channel_socket_new to get channel,
> Which set QIO_CHANNEL_FEATURE_SHUTDOWN already.
>
> Signed-off-by: Wang Guang<wang.guang55@zte.com.cn>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> io/channel-socket.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
Looks good to me - I'll try to get this into 2.9
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2017-04-03 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 1:04 [Qemu-devel] [PATCH v2] migration: Fix colo hang in socket_accept_incoming_migration Guang Wang
2017-04-03 11:04 ` Daniel P. Berrange [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-27 1:58 Guang Wang
2017-03-27 2:47 ` Hailiang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403110435.GM2768@redhat.com \
--to=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wang.guang55@zte.com.cn \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.