From: Peter Zijlstra <peterz@infradead.org>
To: hpa@zytor.com
Cc: linux-tip-commits@vger.kernel.org,
tip-bot for Peter Zijlstra <tipbot@zytor.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
mingo@kernel.org, tglx@linutronix.de, fengguang.wu@intel.com
Subject: Re: [tip:x86/asm] debug: Fix __bug_table[] in arch linker scripts
Date: Mon, 3 Apr 2017 14:25:01 +0200 [thread overview]
Message-ID: <20170403122501.GA3093@worktop> (raw)
In-Reply-To: <EFEC808A-ED79-4161-B972-EDE9820B70DE@zytor.com>
On Mon, Apr 03, 2017 at 02:57:48AM -0700, hpa@zytor.com wrote:
> On April 3, 2017 1:27:49 AM PDT, tip-bot for Peter Zijlstra <tipbot@zytor.com> wrote:
> >diff --git a/arch/x86/kernel/vmlinux.lds.S
> >b/arch/x86/kernel/vmlinux.lds.S
> >index c74ae9c..c8a3b61 100644
> >--- a/arch/x86/kernel/vmlinux.lds.S
> >+++ b/arch/x86/kernel/vmlinux.lds.S
> >@@ -146,6 +146,7 @@ SECTIONS
> > _edata = .;
> > } :data
> >
> >+ BUG_TABLE
> >
> > . = ALIGN(PAGE_SIZE);
> > __vvar_page = .;
>
> Case in point why we want structured linker tables, btw...
Yes.
Btw, can you explain why x86 builds and works without this patch?
Because as far as I understand this (which isn't very far), we should
fail linking with an unresolved symbol without this.
prev parent reply other threads:[~2017-04-03 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 13:02 [tip:x86/asm 3/3] lib/bug.c:135: undefined reference to `__start___bug_table' kbuild test robot
2017-03-30 15:49 ` Peter Zijlstra
2017-03-30 15:53 ` Peter Zijlstra
2017-03-31 0:27 ` Fengguang Wu
2017-04-03 8:27 ` [tip:x86/asm] debug: Fix __bug_table[] in arch linker scripts tip-bot for Peter Zijlstra
2017-04-03 9:57 ` hpa
2017-04-03 12:25 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403122501.GA3093@worktop \
--to=peterz@infradead.org \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tipbot@zytor.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.