From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv1fv-00083A-Ut for qemu-devel@nongnu.org; Mon, 03 Apr 2017 09:05:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cv1fu-0002g7-KF for qemu-devel@nongnu.org; Mon, 03 Apr 2017 09:05:39 -0400 Date: Mon, 3 Apr 2017 14:05:17 +0100 From: "Daniel P. Berrange" Message-ID: <20170403130517.GX2768@redhat.com> Reply-To: "Daniel P. Berrange" References: <1490879707-6060-1-git-send-email-armbru@redhat.com> <1490879707-6060-4-git-send-email-armbru@redhat.com> <20170403114855.GV2768@redhat.com> <6516cecc-4f5f-9255-3890-7fed57ab7eb4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6516cecc-4f5f-9255-3890-7fed57ab7eb4@redhat.com> Subject: Re: [Qemu-devel] [RFC v2 for-2.9 03/10] io vnc sockets: Clean up SocketAddressKind switches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Markus Armbruster , qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org, mitake.hitoshi@lab.ntt.co.jp, jcody@redhat.com, pbonzini@redhat.com, namei.unix@gmail.com On Mon, Apr 03, 2017 at 02:50:12PM +0200, Max Reitz wrote: > On 03.04.2017 13:48, Daniel P. Berrange wrote: > > On Thu, Mar 30, 2017 at 03:15:00PM +0200, Markus Armbruster wrote: > >> We have quite a few switches over SocketAddressKind. Some have case > >> labels for all enumeration values, others rely on a default label. > >> Some abort when the value isn't a valid SocketAddressKind, others > >> report an error then. > >> > >> Unify as follows. Always provide case labels for all enumeration > >> values, to clarify intent. Abort when the value isn't a valid > >> SocketAddressKind, because the program state is messed up then. > >> > >> Improve a few error messages while there. > >> > >> Signed-off-by: Markus Armbruster > >> Reviewed-by: Max Reitz > >> --- > >> io/dns-resolver.c | 7 +++++-- > >> ui/vnc.c | 18 ++++++++++++------ > >> util/qemu-sockets.c | 4 +--- > >> 3 files changed, 18 insertions(+), 11 deletions(-) > >> > >> diff --git a/io/dns-resolver.c b/io/dns-resolver.c > >> index 0ac6b23..a407075 100644 > >> --- a/io/dns-resolver.c > >> +++ b/io/dns-resolver.c > >> @@ -164,9 +164,12 @@ int qio_dns_resolver_lookup_sync(QIODNSResolver *resolver, > >> addrs, > >> errp); > >> > >> + case SOCKET_ADDRESS_KIND_FD: > >> + error_setg(errp, "Unsupported socket address type 'fd'"); > >> + return -1; > >> + > >> default: > >> - error_setg(errp, "Unknown socket address kind"); > >> - return -1; > >> + abort(); > >> } > >> } > > > > Just repeating my v1 comments - this needs to be treating KIND_FD as a no-op, > > rather than raising an error. > > Do you want to write a patch? Markus is on vacation and since this is > not a regression, dropping this patch from my queue wouldn't do any good > either. Ok, i'll do a follow up. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|