From: Brian Norris <briannorris@chromium.org>
To: Dmitry Torokhov <dtor@google.com>
Cc: Xinming Hu <huxinming820@gmail.com>,
Linux Wireless <linux-wireless@vger.kernel.org>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Rajat Jain <rajatja@google.com>,
Amitkumar Karwar <akarwar@marvell.com>,
Cathy Luo <cluo@marvell.com>, Xinming Hu <huxm@marvell.com>
Subject: Re: [PATCH 3/3] mwifiex: pcie: avoid hardcode wifi-only firmware name
Date: Mon, 3 Apr 2017 11:48:58 -0700 [thread overview]
Message-ID: <20170403184857.GC116262@google.com> (raw)
In-Reply-To: <CAE_wzQ-6irwa5_HeQuRk3kOcLBrYR9N9XNFPg_xx7tmWcHdgGA@mail.gmail.com>
On Fri, Mar 31, 2017 at 03:50:27PM -0700, Dmitry Torokhov wrote:
> That said, I consider the whole wifi-only firmware business is quite
> fragile. Can we have unified firmware and have driver figure out what
> part shoudl be [re]loaded?
+1. I think we should really give a stab at this first, and *then* see
how we want to patch up the flagging of support on a per-chipset basis.
As-is, you're wasting filesystem space on a duplicate firmware blob,
that we have to make sure gets updated in sync with the combined
firmware every time there's an update.
Proof of the duplicate blob -- the latter portion of the combined FW is
identical to the WLAN-only:
$ cmp mrvl/pcie{usb8997_combo,8997_wlan}_v4.bin $((0x2919c)); echo $?
0
Brian
next prev parent reply other threads:[~2017-04-03 18:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 9:19 [PATCH 1/3] mwifiex: remove unnecessary wakeup interrupt number sanity check Xinming Hu
2017-03-30 9:19 ` [PATCH 2/3] mwifiex: using general print function during device intialization Xinming Hu
2017-03-31 22:46 ` Dmitry Torokhov
2017-04-03 18:42 ` Brian Norris
2017-04-05 6:41 ` Xinming Hu
2017-03-30 9:19 ` [PATCH 3/3] mwifiex: pcie: avoid hardcode wifi-only firmware name Xinming Hu
2017-03-31 22:50 ` Dmitry Torokhov
2017-04-03 18:48 ` Brian Norris [this message]
2017-04-06 8:08 ` [EXT] " Xinming Hu
2017-04-06 8:05 ` Xinming Hu
2017-04-05 10:47 ` [3/3] " Kalle Valo
[not found] ` <20170405104711.1092260DC7@smtp.codeaurora.org>
2017-04-06 8:14 ` RE:] " Xinming Hu
2017-03-31 22:37 ` [PATCH 1/3] mwifiex: remove unnecessary wakeup interrupt number sanity check Dmitry Torokhov
2017-04-03 18:33 ` Brian Norris
2017-04-05 5:23 ` Xinming Hu
2017-04-05 5:16 ` [EXT] " Xinming Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403184857.GC116262@google.com \
--to=briannorris@chromium.org \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=dtor@google.com \
--cc=huxinming820@gmail.com \
--cc=huxm@marvell.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.