All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: JinHuiEric.Huang-5C7GfCeVMHo@public.gmane.org
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [bug report] drm/amd/powerplay: add Vega10 powerplay support (v5)
Date: Mon, 3 Apr 2017 22:38:31 +0300	[thread overview]
Message-ID: <20170403193831.GA4692@mwanda> (raw)

Hello Eric Huang,

The patch f83a9991648b: "drm/amd/powerplay: add Vega10 powerplay
support (v5)" from Mar 6, 2017, leads to the following static checker
warning:

	drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_processpptables.c:436 get_gfxclk_voltage_dependency_table()
	warn: mask and shift to zero

drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_processpptables.c
   428  
   429          for (i = 0; i < clk_table->count; i++) {
   430                  clk_table->entries[i].vddInd =
   431                                  clk_dep_table->entries[i].ucVddInd;
   432                  clk_table->entries[i].clk =
   433                                  le32_to_cpu(clk_dep_table->entries[i].ulClk);
   434                  clk_table->entries[i].cks_enable =
   435                                  (((clk_dep_table->entries[i].usCKSVOffsetandDisable & 0x80)
   436                                                  >> 15) == 0) ? 1 : 0;

We aways set .cks_enable to true because 0x80 >> 15 is zero.

   437                  clk_table->entries[i].cks_voffset =
   438                                  (clk_dep_table->entries[i].usCKSVOffsetandDisable & 0x7F);
   439                  clk_table->entries[i].sclk_offset =
   440                                  clk_dep_table->entries[i].usAVFSOffset;
   441          }
   442  

regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

                 reply	other threads:[~2017-04-03 19:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170403193831.GA4692@mwanda \
    --to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=JinHuiEric.Huang-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.