From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Bride <jim.bride@linux.intel.com>
Subject: Re: [PATCH] drm/i915/psr: Clean-up
	intel_enable_source_psr1()
Date: Mon, 3 Apr 2017 15:05:21 -0700
Message-ID: <20170403220521.GB31776@shiv>
References: <1491239275-8408-1-git-send-email-jim.bride@linux.intel.com>
 <1491241363.3191.3.camel@rdvivi-vienna>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 4F62B6E443
 for <intel-gfx@lists.freedesktop.org>; Mon,  3 Apr 2017 22:07:18 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1491241363.3191.3.camel@rdvivi-vienna>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "Boyer,
 Wayne" <wayne.boyer@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBBcHIgMDMsIDIwMTcgYXQgMDU6NDI6MzlQTSArMDAwMCwgVml2aSwgUm9kcmlnbyB3
cm90ZToKPiBPbiBNb24sIDIwMTctMDQtMDMgYXQgMTA6MDcgLTA3MDAsIEppbSBCcmlkZSB3cm90
ZToKPiA+IE9uIFNLTCsgdGhlcmUgaXMgYSBiaXQgaW4gU1JEX0NUTCB0aGF0IHNvZnR3YXJlIGlz
IG5vdCBzdXBwb3NlZCB0bwo+ID4gbW9kaWZ5LCBidXQgd2UgY3VycmVudGx5IGNsb2JiZXIgdGhh
dCBiaXQgd2hlbiB3ZSBlbmFibGUgUFNSLiAgSW4KPiA+IG9yZGVyIHRvIHByZXNlcnZlIHRoZSB2
YWx1ZSBvZiB0aGF0IGJpdCwgZ28gYWhlYWQgYW5kIHJlYWQgU1JEX0NUTCBhbmQKPiA+IGRvIGEg
ZmllbGQtd2lzZSBzZXR0aW5nIG9mIHRoZSB2YXJpb3VzIGJpdHMgdGhhdCB3ZSBuZWVkIHRvIGlu
aXRpYWxpemUKPiA+IGJlZm9yZSB3cml0aW5nIHRoZSByZWdpc3RlciBiYWNrIG91dC4gIEFkZGl0
aW9uYWxseSwgZ28gYWhlYWQgYW5kCj4gPiBleHBsaWNpdGx5IGRpc2FibGUgc2luZ2xlLWZyYW1l
IHVwZGF0ZSBzaW5jZSB3ZSBhcmVuJ3QgY3VycmVudGx5Cj4gPiBzdXBwb3J0aW5nIGl0Lgo+ID4g
Cj4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4gQ2M6IFdh
eW5lIEJveWVyIDx3YXluZS5ib3llckBpbnRlbC5jb20+Cj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6
IEppbSBCcmlkZSA8amltLmJyaWRlQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZl
cnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggIHwgIDMgKysrCj4gPiAgZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfcHNyLmMgfCAyMyArKysrKysrKysrKysrKysrKysrKystLQo+ID4gIDIgZmls
ZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pOTE1X3JlZy5oCj4gPiBpbmRleCAxMWIxMmY0Li41NGQzOWU0IDEwMDY0NAo+ID4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gQEAgLTM1OTAsMTQgKzM1OTAsMTcgQEAgZW51bSB7
Cj4gPiAgI2RlZmluZSAgIEVEUF9QU1JfU0tJUF9BVVhfRVhJVAkJCSgxPDwxMikKPiA+ICAjZGVm
aW5lICAgRURQX1BTUl9UUDFfVFAyX1NFTAkJCSgwPDwxMSkKPiA+ICAjZGVmaW5lICAgRURQX1BT
Ul9UUDFfVFAzX1NFTAkJCSgxPDwxMSkKPiA+ICsjZGVmaW5lICAgRURQX1BTUl9UUDJfVFAzX1RJ
TUVfTUFTSyAgICAgICAgICAgICAoMzw8OCkKPiA+ICAjZGVmaW5lICAgRURQX1BTUl9UUDJfVFAz
X1RJTUVfNTAwdXMJCSgwPDw4KQo+ID4gICNkZWZpbmUgICBFRFBfUFNSX1RQMl9UUDNfVElNRV8x
MDB1cwkJKDE8PDgpCj4gPiAgI2RlZmluZSAgIEVEUF9QU1JfVFAyX1RQM19USU1FXzI1MDB1cwkJ
KDI8PDgpCj4gPiAgI2RlZmluZSAgIEVEUF9QU1JfVFAyX1RQM19USU1FXzB1cwkJKDM8PDgpCj4g
PiArI2RlZmluZSAgIEVEUF9QU1JfVFAxX1RJTUVfTUFTSyAgICAgICAgICAgICAgICAgKDB4Mzw8
NCkKPiA+ICAjZGVmaW5lICAgRURQX1BTUl9UUDFfVElNRV81MDB1cwkJKDA8PDQpCj4gPiAgI2Rl
ZmluZSAgIEVEUF9QU1JfVFAxX1RJTUVfMTAwdXMJCSgxPDw0KQo+ID4gICNkZWZpbmUgICBFRFBf
UFNSX1RQMV9USU1FXzI1MDB1cwkJKDI8PDQpCj4gPiAgI2RlZmluZSAgIEVEUF9QU1JfVFAxX1RJ
TUVfMHVzCQkJKDM8PDQpCj4gPiArI2RlZmluZSAgIEVEUF9QU1JfSURMRV9GUkFNRV9NQVNLICAg
ICAgICAgICAgICAgKDB4Zjw8MCkKPiA+ICAjZGVmaW5lICAgRURQX1BTUl9JRExFX0ZSQU1FX1NI
SUZUCQkwCj4gPiAgCj4gPiAgI2RlZmluZSBFRFBfUFNSX0FVWF9DVEwJCQkJX01NSU8oZGV2X3By
aXYtPnBzcl9tbWlvX2Jhc2UgKyAweDEwKQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX3Bzci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+
IGluZGV4IGMzNzgwZDAuLmEwNTA4NTkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9wc3IuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNy
LmMKPiA+IEBAIC0yODAsMTcgKzI4MCwzNCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9lbmFibGVfc291
cmNlX3BzcjEoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+ICAJICogd2l0aCB0aGUgNSBv
ciA2IGlkbGUgcGF0dGVybnMuCj4gPiAgCSAqLwo+ID4gIAl1aW50MzJfdCBpZGxlX2ZyYW1lcyA9
IG1heCg2LCBkZXZfcHJpdi0+dmJ0LnBzci5pZGxlX2ZyYW1lcyk7Cj4gPiAtCXVpbnQzMl90IHZh
bCA9IEVEUF9QU1JfRU5BQkxFOwo+ID4gKwl1aW50MzJfdCB2YWwgPSBJOTE1X1JFQUQoRURQX1BT
Ul9DVEwpOwo+ID4gIAo+ID4gKwl2YWwgfD0gRURQX1BTUl9FTkFCTEU7Cj4gPiArCj4gPiArCS8q
IFdlIGFsd2F5cyBzZXQgdGhlIG1heCBzbGVlcCB0aW1lIHRvIHRoZSBtYXhpbXVtIHZhbHVlLCBz
bwo+ID4gKwkgKiBubyBuZWVkIHRvIHplcm8gb3V0IHRoZSBmaWVsZCBmaXJzdC4KPiA+ICsJICov
Cj4gCj4gSSBiZWxpZXZlIGl0IGlzIGJldHRlciB0byB6ZXJvIG91dCBpbnN0ZWFkIG9mIGFkZGlu
ZyBhIGNvbW1lbnQuCj4gU28gd2UgY291bGQgcGxheSB3aXRoIG1heF9zbGVlcF90aW1lIGlmIG5l
ZWRlZC4KPiAKPiBPdGhlcndpc2Ugd2Ugc2hvdWxkbid0IGFsbG93IHRoZSBmbGV4aWJsZSB2YWx1
ZSBoZXJlIHNvIHdlIHNob3VsZCBjcmVhdGUKPiBhIGRlZmluZSBFRFBfUFNSX01BWF9TTEVFUF9U
SU1FICgweDFmIDw8IDIwKQo+IGFuZCBoZXJlIGRvIGEgdmFsIHw9IEVEUF9QU1JfTUFYX1NMRUVQ
X1RJTUU7CgpUaGF0J3MgZmFpci4gIEknbGwgd2FpdCBhIGJpdCBpbiBjYXNlIHRoZXJlJ3MgZnVy
dGhlciBjb21tZW50cywgYW5kIHRoZW4Kc3BpbiBhIG5ldyB2ZXJzaW9uIHdpdGhvdXQgc2FpZCBj
b21tZW50IGFuZCB3aXRoIHplcm9pbmcgb3V0IHRoZSBmaWVsZC4KCkppbQoKCj4gPiAgCXZhbCB8
PSBtYXhfc2xlZXBfdGltZSA8PCBFRFBfUFNSX01BWF9TTEVFUF9USU1FX1NISUZUOwo+ID4gKwo+
ID4gKwl2YWwgJj0gfkVEUF9QU1JfSURMRV9GUkFNRV9NQVNLOwo+ID4gIAl2YWwgfD0gaWRsZV9m
cmFtZXMgPDwgRURQX1BTUl9JRExFX0ZSQU1FX1NISUZUOwo+ID4gIAo+ID4gKwl2YWwgJj0gfkVE
UF9QU1JfTUlOX0xJTktfRU5UUllfVElNRV9NQVNLOwo+ID4gIAlpZiAoSVNfSEFTV0VMTChkZXZf
cHJpdikpCj4gPiAgCQl2YWwgfD0gRURQX1BTUl9NSU5fTElOS19FTlRSWV9USU1FXzhfTElORVM7
Cj4gPiAgCj4gPiAtCWlmIChkZXZfcHJpdi0+cHNyLmxpbmtfc3RhbmRieSkKPiA+ICsJaWYgKGRl
dl9wcml2LT5wc3IubGlua19zdGFuZGJ5KSB7Cj4gPiAgCQl2YWwgfD0gRURQX1BTUl9MSU5LX1NU
QU5EQlk7Cj4gPiAgCj4gPiArCQkvKiBTRlUgc2hvdWxkIG9ubHkgYmUgZW5hYmxlZCB3aXRoIGxp
bmsgc3RhbmRieSwgYnV0IGZvcgo+ID4gKwkJICogbm93IHdlIGRvIG5vdCBzdXBwb3J0IGl0LiAq
Lwo+ID4gKwkJdmFsICY9IH5CRFdfUFNSX1NJTkdMRV9GUkFNRTsKPiA+ICsJfSBlbHNlIHsKPiA+
ICsJCXZhbCAmPSB+RURQX1BTUl9MSU5LX1NUQU5EQlk7Cj4gPiArCQl2YWwgJj0gfkJEV19QU1Jf
U0lOR0xFX0ZSQU1FOwo+ID4gKwl9Cj4gPiArCj4gPiArCXZhbCAmPSB+RURQX1BTUl9UUDFfVElN
RV9NQVNLOwo+ID4gIAlpZiAoZGV2X3ByaXYtPnZidC5wc3IudHAxX3dha2V1cF90aW1lID4gNSkK
PiA+ICAJCXZhbCB8PSBFRFBfUFNSX1RQMV9USU1FXzI1MDB1czsKPiA+ICAJZWxzZSBpZiAoZGV2
X3ByaXYtPnZidC5wc3IudHAxX3dha2V1cF90aW1lID4gMSkKPiA+IEBAIC0zMDAsNiArMzE3LDcg
QEAgc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX3NvdXJjZV9wc3IxKHN0cnVjdCBpbnRlbF9kcCAq
aW50ZWxfZHApCj4gPiAgCWVsc2UKPiA+ICAJCXZhbCB8PSBFRFBfUFNSX1RQMV9USU1FXzB1czsK
PiA+ICAKPiA+ICsJdmFsICY9IH5FRFBfUFNSX1RQMl9UUDNfVElNRV9NQVNLOwo+ID4gIAlpZiAo
ZGV2X3ByaXYtPnZidC5wc3IudHAyX3RwM193YWtldXBfdGltZSA+IDUpCj4gPiAgCQl2YWwgfD0g
RURQX1BTUl9UUDJfVFAzX1RJTUVfMjUwMHVzOwo+ID4gIAllbHNlIGlmIChkZXZfcHJpdi0+dmJ0
LnBzci50cDJfdHAzX3dha2V1cF90aW1lID4gMSkKPiA+IEBAIC0zMDksNiArMzI3LDcgQEAgc3Rh
dGljIHZvaWQgaW50ZWxfZW5hYmxlX3NvdXJjZV9wc3IxKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf
ZHApCj4gPiAgCWVsc2UKPiA+ICAJCXZhbCB8PSBFRFBfUFNSX1RQMl9UUDNfVElNRV8wdXM7Cj4g
PiAgCj4gPiArCXZhbCAmPSB+RURQX1BTUl9UUDFfVFAzX1NFTDsKPiA+ICAJaWYgKGludGVsX2Rw
X3NvdXJjZV9zdXBwb3J0c19oYnIyKGludGVsX2RwKSAmJgo+ID4gIAkgICAgZHJtX2RwX3RwczNf
c3VwcG9ydGVkKGludGVsX2RwLT5kcGNkKSkKPiA+ICAJCXZhbCB8PSBFRFBfUFNSX1RQMV9UUDNf
U0VMOwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ
bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0
cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK