From: Christoph Hellwig <hch@infradead.org>
To: Cathy Avery <cavery@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
kys@microsoft.com, haiyangz@microsoft.com,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
stephen@networkplumber.org, dan.carpenter@oracle.com,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] scsi: storvsc: Add support for FC rport.
Date: Mon, 3 Apr 2017 23:53:31 -0700 [thread overview]
Message-ID: <20170404065331.GA2626@infradead.org> (raw)
In-Reply-To: <58E24A9A.30200@redhat.com>
On Mon, Apr 03, 2017 at 09:14:02AM -0400, Cathy Avery wrote:
> On 04/03/2017 08:17 AM, Christoph Hellwig wrote:
> > > if (host->transportt == fc_transport_template) {
> > > + struct fc_rport_identifiers ids = {
> > > + .roles = FC_PORT_ROLE_FCP_TARGET,
> > > + };
> > I don't think storvsc ever acts as FCP target.
>
> In order to implement the work around so that the scsi scan works indicating
> FC_PORT_ROLE_FCP_TARGET as a role was necessary due to its test in
> fc_scsi_scan_rport. The idea here is to avoid making any changes to the
> fc_transport driver which was of some concern.
Please add a FC_PORT_ROLE_FCP_DUMMY_INITIATOR role instead.
next prev parent reply other threads:[~2017-04-04 6:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 11:33 [PATCH v2] scsi: storvsc: Add support for FC rport Cathy Avery
2017-04-03 12:17 ` Christoph Hellwig
2017-04-03 12:17 ` Christoph Hellwig
2017-04-03 13:14 ` Cathy Avery
2017-04-04 6:53 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-17 15:17 Cathy Avery
2017-03-17 15:17 ` Cathy Avery
2017-03-21 18:10 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404065331.GA2626@infradead.org \
--to=hch@infradead.org \
--cc=cavery@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.