From: Thierry Reding <treding@nvidia.com>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: <davem@davemloft.net>, <clabbe.montjoie@gmail.com>,
<niklas.cassel@axis.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/4] net: stmmac: adding multiple buffers for rx
Date: Tue, 4 Apr 2017 21:23:18 +0200 [thread overview]
Message-ID: <20170404192317.GE24271@ulmo.ba.sec> (raw)
In-Reply-To: <4f35e9a73521ba4ab4868c75950166fb757b5f8a.1491328304.git.jpinto@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Tue, Apr 04, 2017 at 06:54:25PM +0100, Joao Pinto wrote:
[...]
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
[...]
> @@ -3402,6 +3474,9 @@ static irqreturn_t stmmac_interrupt(int irq, void *dev_id)
>
> if (priv->synopsys_id >= DWMAC_CORE_4_00) {
> for (queue = 0; queue < queues_count; queue++) {
> + struct stmmac_rx_queue *rx_q =
> + &priv->rx_queue[queue];
Found one more: the indentation here looks wrong. I think it's more
idiomatic to indent by at least a tab in such cases.
> +
> status |=
> priv->hw->mac->host_mtl_irq_status(priv->hw,
> queue);
This is becoming quite unwieldy because of the indentation levels. Maybe
this could be split out into a separate function. Could be a separate
patch, though.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-04-04 19:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 17:54 [PATCH 0/4 net-next] net: stmmac: adding multiple buffers Joao Pinto
2017-04-04 17:54 ` [PATCH 1/4] net: stmmac: break some functions into RX and TX scopes Joao Pinto
2017-04-04 17:54 ` [PATCH 2/4] net: stmmac: adding multiple buffers for rx Joao Pinto
2017-04-04 19:14 ` Thierry Reding
2017-04-04 19:15 ` Thierry Reding
2017-04-04 19:23 ` Thierry Reding [this message]
2017-04-04 17:54 ` [PATCH 3/4] net: stmmac: adding multiple buffers for TX Joao Pinto
2017-04-04 19:19 ` Thierry Reding
2017-04-04 17:54 ` [PATCH 4/4] net: stmmac: adding multiple napi mechanism Joao Pinto
2017-04-04 19:28 ` Thierry Reding
2017-04-04 18:57 ` [PATCH 1/4] net: stmmac: break some functions into RX and TX scopes Thierry Reding
2017-04-05 9:04 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404192317.GE24271@ulmo.ba.sec \
--to=treding@nvidia.com \
--cc=Joao.Pinto@synopsys.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.