All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Niranjana Vishwanathapura
	<niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Alex Vesker <valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH rdma-next 0/6] Enhanced mode for IPoIB driver
Date: Tue, 4 Apr 2017 13:47:50 -0600	[thread overview]
Message-ID: <20170404194750.GC10780@obsidianresearch.com> (raw)
In-Reply-To: <20170404191732.31895-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

On Tue, Apr 04, 2017 at 10:17:26PM +0300, Leon Romanovsky wrote:
> Hi Doug,
> 
> This patchset mostly comes from Erez with one exception in the first patch.
> 
> That patch origins from two different commits, first from Niranjana who added
> RDMA netdev interface and second from Erez who added IPoIB support.
> 
> During the preparation to submission, I squashed their commits into one
> and refactored code to allow submission as a standalone topic without creating
> dependecies between different submissions. This caused to change in author line.
> I hope that it doesn't really matter and it won't stop you from merging it.
> 
> Per-your request, I based this patch set on v4.11-rc3.

I didn't dig into the details of the ipoib part, but I think the
core change and the overall look is now what I would expect. modulo
the little comments

It would still have been nicer to isolate the 'default' implementation
so those functions did not touch ipoib_priv, but that is also
something that could be done in a followup..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-04-04 19:47 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 19:17 [PATCH rdma-next 0/6] Enhanced mode for IPoIB driver Leon Romanovsky
     [not found] ` <20170404191732.31895-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-04-04 19:17   ` [PATCH rdma-next 1/6] IB/IPoIB: Introduce RDMA netdev interface and IPoIB structs Leon Romanovsky
     [not found]     ` <20170404191732.31895-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-04-04 19:37       ` Jason Gunthorpe
     [not found]         ` <20170404193730.GA10780-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-04 19:48           ` Bart Van Assche
2017-04-04 19:56           ` Leon Romanovsky
2017-04-04 19:17   ` [PATCH rdma-next 2/6] IB/IPoIB: Separate control and data related initializations Leon Romanovsky
2017-04-04 19:17   ` [PATCH rdma-next 3/6] IB/IPoIB: Separate control from HW operation on ipoib_open/stop ndo Leon Romanovsky
2017-04-04 19:17   ` [PATCH rdma-next 4/6] IB/IPoIB: Rename qpn to be dqpn in ipoib_send and post_send functions Leon Romanovsky
     [not found]     ` <20170404191732.31895-5-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-04-05  0:56       ` kbuild test robot
     [not found]         ` <201704050840.SLVNyMTT%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-05 10:38           ` Leon Romanovsky
     [not found]             ` <20170405103838.GE20443-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-04-05 15:00               ` Bart Van Assche
     [not found]                 ` <1491404447.2787.1.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-04-05 16:35                   ` Leon Romanovsky
2017-04-04 19:17   ` [PATCH rdma-next 5/6] IB/IPoIB: Formatting before adding accelerator to driver Leon Romanovsky
2017-04-04 19:17   ` [PATCH rdma-next 6/6] IB/IPoIB: Support acceleration options callbacks Leon Romanovsky
     [not found]     ` <20170404191732.31895-7-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-04-04 19:42       ` Jason Gunthorpe
     [not found]         ` <20170404194234.GB10780-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-05  6:45           ` Leon Romanovsky
2017-04-05  9:11           ` Erez Shitrit
2017-04-05 11:25           ` Erez Shitrit
2017-04-04 19:46       ` Jason Gunthorpe
     [not found]         ` <20170404194615.GA14681-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-05 11:42           ` Erez Shitrit
2017-04-04 19:47   ` Jason Gunthorpe [this message]
     [not found]     ` <20170404194750.GC10780-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-04 19:57       ` [PATCH rdma-next 0/6] Enhanced mode for IPoIB driver Leon Romanovsky
     [not found]         ` <20170404195720.GA20443-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-04-04 20:14           ` Jason Gunthorpe
     [not found]             ` <20170404201408.GA16818-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-05 10:47               ` Leon Romanovsky
2017-04-04 19:50   ` Weiny, Ira
     [not found]     ` <2807E5FD2F6FDA4886F6618EAC48510E67C8CAA0-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-04-04 20:03       ` Leon Romanovsky
     [not found]         ` <20170404200335.GB20443-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-04-06  0:54           ` Weiny, Ira
     [not found]             ` <2807E5FD2F6FDA4886F6618EAC48510E67C8DAB7-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-04-06  5:28               ` Leon Romanovsky
     [not found]                 ` <20170406052820.GB2269-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-04-06 15:10                   ` Vishwanathapura, Niranjana
     [not found]                     ` <20170406151014.GA173962-wPcXA7LoDC+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2017-04-10  8:02                       ` Leon Romanovsky
     [not found]                         ` <20170410080228.GP2269-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-04-10 15:40                           ` Jason Gunthorpe
     [not found]                             ` <20170410154039.GA7056-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-12  5:22                               ` Leon Romanovsky
     [not found]                                 ` <20170412052223.GQ2269-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-04-12 15:50                                   ` Jason Gunthorpe
2017-04-06  1:50   ` Dennis Dalessandro
     [not found]     ` <456a1a5f-26a4-13a6-744c-02679e0fc90b-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-06  5:38       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170404194750.GC10780@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=niranjana.vishwanathapura-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.