From mboxrd@z Thu Jan  1 00:00:00 1970
From: Manasi Navare <manasi.d.navare@intel.com>
Subject: Re: [PATCH v3 13/14] drm/i915/dp: use readb and writeb
 calls for single byte DPCD access
Date: Tue, 4 Apr 2017 18:28:22 -0700
Message-ID: <20170405012821.GJ2688@intel.com>
References: <cover.1490712890.git.jani.nikula@intel.com>
 <fc13057108c4b691b60744787b5f3c8d1da3126e.1490712890.git.jani.nikula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 452F66E0EB
 for <intel-gfx@lists.freedesktop.org>; Wed,  5 Apr 2017 01:24:30 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <fc13057108c4b691b60744787b5f3c8d1da3126e.1490712890.git.jani.nikula@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dhinakaran.pandiyan@intel.com
List-Id: intel-gfx@lists.freedesktop.org

WWVzIHRoaXMgaXMgYSBnb29kIG9wdGltaXphdGlvbi4KCk1hbmFzaQoKT24gVHVlLCBNYXIgMjgs
IDIwMTcgYXQgMDU6NTk6MTNQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gVGhpcyBpcyB3
aGF0IHdlIGhhdmUgdGhlIHJlYWRiIGFuZCB3cml0ZWIgdmFyaWFudHMgZm9yLiBEbyBzb21lIG1p
bm9yCj4gcmV0dXJuIHZhbHVlIGFuZCB2YXJpYWJsZSBjbGVhbnVwIHdoaWxlIGF0IGl0Lgo+IAo+
IENjOiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+IENjOiBWaWxs
ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYt
Ynk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CiAgUmV2aWV3ZWQtYnk6IDxt
YW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kcC5jIHwgMzcgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAx
IGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4gCj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9kcC5jCj4gaW5kZXggNmY3NDM0OTA4NTViLi44MTY4MmZkMjgwNGIgMTAw
NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtMzY2MSw5ICszNjYxLDkgQEAgaW50ZWxf
ZWRwX2luaXRfZHBjZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJCXVpbnQ4X3QgZnJh
bWVfc3luY19jYXA7Cj4gIAo+ICAJCWRldl9wcml2LT5wc3Iuc2lua19zdXBwb3J0ID0gdHJ1ZTsK
PiAtCQlkcm1fZHBfZHBjZF9yZWFkKCZpbnRlbF9kcC0+YXV4LAo+IC0JCQkJIERQX1NJTktfREVW
SUNFX0FVWF9GUkFNRV9TWU5DX0NBUCwKPiAtCQkJCSAmZnJhbWVfc3luY19jYXAsIDEpOwo+ICsJ
CWRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LAo+ICsJCQkJICBEUF9TSU5LX0RFVklD
RV9BVVhfRlJBTUVfU1lOQ19DQVAsCj4gKwkJCQkgICZmcmFtZV9zeW5jX2NhcCk7Cj4gIAkJZGV2
X3ByaXYtPnBzci5hdXhfZnJhbWVfc3luYyA9IGZyYW1lX3N5bmNfY2FwID8gdHJ1ZSA6IGZhbHNl
Owo+ICAJCS8qIFBTUjIgbmVlZHMgZnJhbWUgc3luYyBhcyB3ZWxsICovCj4gIAkJZGV2X3ByaXYt
PnBzci5wc3IyX3N1cHBvcnQgPSBkZXZfcHJpdi0+cHNyLmF1eF9mcmFtZV9zeW5jOwo+IEBAIC0z
NzM3LDggKzM3MzcsOCBAQCBpbnRlbF9kcF9nZXRfZHBjZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVs
X2RwKQo+ICAJCWludGVsX2RwX3NldF9jb21tb25fcmF0ZXMoaW50ZWxfZHApOwo+ICAJfQo+ICAK
PiAtCWlmIChkcm1fZHBfZHBjZF9yZWFkKCZpbnRlbF9kcC0+YXV4LCBEUF9TSU5LX0NPVU5ULAo+
IC0JCQkgICAgICZpbnRlbF9kcC0+c2lua19jb3VudCwgMSkgPCAwKQo+ICsJaWYgKGRybV9kcF9k
cGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9TSU5LX0NPVU5ULAo+ICsJCQkgICAgICAmaW50
ZWxfZHAtPnNpbmtfY291bnQpIDw9IDApCj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAKPiAgCS8qCj4g
QEAgLTM3NzUsNyArMzc3NSw3IEBAIGludGVsX2RwX2dldF9kcGNkKHN0cnVjdCBpbnRlbF9kcCAq
aW50ZWxfZHApCj4gIHN0YXRpYyBib29sCj4gIGludGVsX2RwX2Nhbl9tc3Qoc3RydWN0IGludGVs
X2RwICppbnRlbF9kcCkKPiAgewo+IC0JdTggYnVmWzFdOwo+ICsJdTggbXN0bV9jYXA7Cj4gIAo+
ICAJaWYgKCFpOTE1LmVuYWJsZV9kcF9tc3QpCj4gIAkJcmV0dXJuIGZhbHNlOwo+IEBAIC0zNzg2
LDEwICszNzg2LDEwIEBAIGludGVsX2RwX2Nhbl9tc3Qoc3RydWN0IGludGVsX2RwICppbnRlbF9k
cCkKPiAgCWlmIChpbnRlbF9kcC0+ZHBjZFtEUF9EUENEX1JFVl0gPCAweDEyKQo+ICAJCXJldHVy
biBmYWxzZTsKPiAgCj4gLQlpZiAoZHJtX2RwX2RwY2RfcmVhZCgmaW50ZWxfZHAtPmF1eCwgRFBf
TVNUTV9DQVAsIGJ1ZiwgMSkgIT0gMSkKPiArCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxf
ZHAtPmF1eCwgRFBfTVNUTV9DQVAsICZtc3RtX2NhcCkgIT0gMSkKPiAgCQlyZXR1cm4gZmFsc2U7
Cj4gIAo+IC0JcmV0dXJuIGJ1ZlswXSAmIERQX01TVF9DQVA7Cj4gKwlyZXR1cm4gbXN0bV9jYXAg
JiBEUF9NU1RfQ0FQOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZAo+IEBAIC0zOTM1LDkgKzM5MzUs
OCBAQCBpbnQgaW50ZWxfZHBfc2lua19jcmMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgdTgg
KmNyYykKPiAgc3RhdGljIGJvb2wKPiAgaW50ZWxfZHBfZ2V0X3NpbmtfaXJxKHN0cnVjdCBpbnRl
bF9kcCAqaW50ZWxfZHAsIHU4ICpzaW5rX2lycV92ZWN0b3IpCj4gIHsKPiAtCXJldHVybiBkcm1f
ZHBfZHBjZF9yZWFkKCZpbnRlbF9kcC0+YXV4LAo+IC0JCQkJICAgICAgIERQX0RFVklDRV9TRVJW
SUNFX0lSUV9WRUNUT1IsCj4gLQkJCQkgICAgICAgc2lua19pcnFfdmVjdG9yLCAxKSA9PSAxOwo+
ICsJcmV0dXJuIGRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9ERVZJQ0VfU0VS
VklDRV9JUlFfVkVDVE9SLAo+ICsJCQkJIHNpbmtfaXJxX3ZlY3RvcikgPT0gMTsKPiAgfQo+ICAK
PiAgc3RhdGljIGJvb2wKPiBAQCAtNDAwMCwxMyArMzk5OSwxMyBAQCBzdGF0aWMgdWludDhfdCBp
bnRlbF9kcF9hdXRvdGVzdF9saW5rX3RyYWluaW5nKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAp
Cj4gIHN0YXRpYyB1aW50OF90IGludGVsX2RwX2F1dG90ZXN0X3ZpZGVvX3BhdHRlcm4oc3RydWN0
IGludGVsX2RwICppbnRlbF9kcCkKPiAgewo+ICAJdWludDhfdCB0ZXN0X3BhdHRlcm47Cj4gLQl1
aW50MTZfdCB0ZXN0X21pc2M7Cj4gKwl1aW50OF90IHRlc3RfbWlzYzsKPiAgCV9fYmUxNiBoX3dp
ZHRoLCB2X2hlaWdodDsKPiAgCWludCBzdGF0dXMgPSAwOwo+ICAKPiAgCS8qIFJlYWQgdGhlIFRF
U1RfUEFUVEVSTiAoRFAgQ1RTIDMuMS41KSAqLwo+IC0Jc3RhdHVzID0gZHJtX2RwX2RwY2RfcmVh
ZCgmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9QQVRURVJOLAo+IC0JCQkJICAmdGVzdF9wYXR0ZXJu
LCAxKTsKPiArCXN0YXR1cyA9IGRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9U
RVNUX1BBVFRFUk4sCj4gKwkJCQkgICAmdGVzdF9wYXR0ZXJuKTsKPiAgCWlmIChzdGF0dXMgPD0g
MCkgewo+ICAJCURSTV9ERUJVR19LTVMoIlRlc3QgcGF0dGVybiByZWFkIGZhaWxlZFxuIik7Cj4g
IAkJcmV0dXJuIERQX1RFU1RfTkFLOwo+IEBAIC00MDI4LDggKzQwMjcsOCBAQCBzdGF0aWMgdWlu
dDhfdCBpbnRlbF9kcF9hdXRvdGVzdF92aWRlb19wYXR0ZXJuKHN0cnVjdCBpbnRlbF9kcCAqaW50
ZWxfZHApCj4gIAkJcmV0dXJuIERQX1RFU1RfTkFLOwo+ICAJfQo+ICAKPiAtCXN0YXR1cyA9IGRy
bV9kcF9kcGNkX3JlYWQoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfTUlTQzAsCj4gLQkJCQkgICZ0
ZXN0X21pc2MsIDEpOwo+ICsJc3RhdHVzID0gZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5h
dXgsIERQX1RFU1RfTUlTQzAsCj4gKwkJCQkgICAmdGVzdF9taXNjKTsKPiAgCWlmIChzdGF0dXMg
PD0gMCkgewo+ICAJCURSTV9ERUJVR19LTVMoIlRFU1QgTUlTQyByZWFkIGZhaWxlZFxuIik7Cj4g
IAkJcmV0dXJuIERQX1RFU1RfTkFLOwo+IEBAIC00MDg4LDEwICs0MDg3LDggQEAgc3RhdGljIHVp
bnQ4X3QgaW50ZWxfZHBfYXV0b3Rlc3RfZWRpZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+
ICAJCSAqLwo+ICAJCWJsb2NrICs9IGludGVsX2Nvbm5lY3Rvci0+ZGV0ZWN0X2VkaWQtPmV4dGVu
c2lvbnM7Cj4gIAo+IC0JCWlmICghZHJtX2RwX2RwY2Rfd3JpdGUoJmludGVsX2RwLT5hdXgsCj4g
LQkJCQkJRFBfVEVTVF9FRElEX0NIRUNLU1VNLAo+IC0JCQkJCSZibG9jay0+Y2hlY2tzdW0sCj4g
LQkJCQkJMSkpCj4gKwkJaWYgKGRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBf
VEVTVF9FRElEX0NIRUNLU1VNLAo+ICsJCQkJICAgICAgIGJsb2NrLT5jaGVja3N1bSkgPD0gMCkK
PiAgCQkJRFJNX0RFQlVHX0tNUygiRmFpbGVkIHRvIHdyaXRlIEVESUQgY2hlY2tzdW1cbiIpOwo+
ICAKPiAgCQl0ZXN0X3Jlc3VsdCA9IERQX1RFU1RfQUNLIHwgRFBfVEVTVF9FRElEX0NIRUNLU1VN
X1dSSVRFOwo+IC0tIAo+IDIuMS40Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy
ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp
bmZvL2ludGVsLWdmeAo=