From: "Daniel P. Berrange" <berrange@redhat.com>
To: jemmy858585@gmail.com
Cc: qemu-devel@nongnu.org, famz@redhat.com, qemu-block@nongnu.org,
quintela@redhat.com, dgilbert@redhat.com, stefanha@redhat.com,
Lidong Chen <lidongchen@tencent.com>
Subject: Re: [Qemu-devel] [PATCH v3] migration/block:limit the time used for block migration
Date: Wed, 5 Apr 2017 10:34:41 +0100 [thread overview]
Message-ID: <20170405093441.GH21911@redhat.com> (raw)
In-Reply-To: <1491384478-12325-1-git-send-email-lidongchen@tencent.com>
On Wed, Apr 05, 2017 at 05:27:58PM +0800, jemmy858585@gmail.com wrote:
> From: Lidong Chen <lidongchen@tencent.com>
>
> when migration with high speed, mig_save_device_bulk invoke
> bdrv_is_allocated too frequently, and cause vnc reponse slowly.
> this patch limit the time used for bdrv_is_allocated.
Can you explain why calling bdrv_is_allocated is impacting VNC performance ?
Migration is running in a background thread, so shouldn't be impacting the
main thread which handles VNC, unless the block layer is perhaps acquiring
the global qemu lock ? I wouldn't expect such a lock to be held for just
the bdrv_is_allocated call though.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2017-04-05 9:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 9:27 [Qemu-devel] [PATCH v3] migration/block:limit the time used for block migration jemmy858585
2017-04-05 9:34 ` Daniel P. Berrange [this message]
2017-04-05 10:44 ` 858585 jemmy
2017-04-06 3:18 ` 858585 jemmy
2017-04-06 14:02 ` Stefan Hajnoczi
2017-04-07 1:30 ` 858585 jemmy
2017-04-07 8:26 ` 858585 jemmy
2017-04-07 11:33 ` Stefan Hajnoczi
2017-04-08 10:09 ` Paolo Bonzini
2017-04-10 10:01 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-09 13:06 ` [Qemu-devel] " 858585 jemmy
2017-04-07 11:34 ` Stefan Hajnoczi
2017-04-08 13:17 ` 858585 jemmy
2017-04-10 13:52 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-11 12:19 ` 858585 jemmy
2017-04-11 13:06 ` 858585 jemmy
2017-04-11 15:32 ` Stefan Hajnoczi
2017-05-03 3:44 ` 858585 jemmy
2017-05-03 13:31 ` 858585 jemmy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405093441.GH21911@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=jemmy858585@gmail.com \
--cc=lidongchen@tencent.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.