From: Greg KH <gregkh@linuxfoundation.org>
To: "Rafał Miłecki" <rafal@milecki.pl>
Cc: Amit Pundir <amit.pundir@linaro.org>,
stable@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts
Date: Wed, 5 Apr 2017 12:12:47 +0200 [thread overview]
Message-ID: <20170405101247.GA31998@kroah.com> (raw)
In-Reply-To: <a5a177d1f900d4561eb439f9b502a778@milecki.pl>
On Tue, Apr 04, 2017 at 11:31:46AM +0200, Rafał Miłecki wrote:
> Hi Amit,
>
> On 2017-04-04 08:12, Amit Pundir wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> >
> > Since early BCM5301X days we got abort handler that was removed by
> > commit 937b12306ea79 ("ARM: BCM5301X: remove workaround imprecise abort
> > fault handler"). It assumed we need to deal only with pending aborts
> > left by the bootloader. Unfortunately this isn't true for BCM5301X.
> >
> > When probing PCI config space (device enumeration) it is expected to
> > have master aborts on the PCI bus. Most bridges don't forward (or they
> > allow disabling it) these errors onto the AXI/AMBA bus but not the
> > Northstar (BCM5301X) one.
> >
> > iProc PCIe controller on Northstar seems to be some older one, without
> > a control register for errors forwarding. It means we need to workaround
> > this at platform level. All newer platforms are not affected by this
> > issue.
> >
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > (cherry picked from commit 09f3510fb70a46c8921f2cf4a90dbcae460a6820)
> > Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
>
> I'm sorry but I'm not familiar with your work and I'm missing some cover
> letter explaining what these patches are about.
>
> You seem to be sending this stuff to Greg. Do you wan to have to included in
> some particular stable branch? Which one? Why? Some of these patches are
> clean
> ups, not a really important fixes.
Are the cleanups needed for the "important fixes" that happen later in
the patch series? If not, why would they be in the repo that Amit
pulled these from? Do those developers just blindly backport stuff in?
(might be true, don't know who they are...)
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-05 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 6:12 [PATCH for-4.9 00/33] Stable commits picked up from lede project Amit Pundir
2017-04-04 6:12 ` [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts Amit Pundir
2017-04-04 9:31 ` Rafał Miłecki
2017-04-04 9:45 ` Amit Pundir
2017-04-05 10:12 ` Greg KH [this message]
2017-04-04 6:12 ` [PATCH 02/33] ARM: dts: BCM5301X: Set 5 GHz wireless frequency limits on Netgear R8000 Amit Pundir
2017-04-04 6:12 ` [PATCH 03/33] ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags Amit Pundir
2017-04-04 6:30 ` [PATCH for-4.9 00/33] Stable commits picked up from lede project Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405101247.GA31998@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amit.pundir@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=rafal@milecki.pl \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.