From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Wed, 5 Apr 2017 17:50:32 +0200 Subject: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port In-Reply-To: <20170405172224.38c1f9fb@gmail.com> References: <20170405052847.326-1-ralph.sennhauser@gmail.com> <20170405142824.GB13449@lunn.ch> <20170405172224.38c1f9fb@gmail.com> Message-ID: <20170405155032.GL13449@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > In fact "internet" label on the case is uppercase, would this matter > for you for new bindings, or would you still use the lowercase version? I would use lower case, just to fix with the general convention that interface names are lower case. > > I would say, this is now too late. Changing an interface name will > > break configuration scripts. We are stuck with it. > > > > If it weren't for commit cb4f71c42988 that would have been obvious for > me as well. Yes, that was not nice. But it was also very earlier in the life of 38x, so it just affected a few developers with reference boards, not real products out in the wild, as far as i remember. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port Date: Wed, 5 Apr 2017 17:50:32 +0200 Message-ID: <20170405155032.GL13449@lunn.ch> References: <20170405052847.326-1-ralph.sennhauser@gmail.com> <20170405142824.GB13449@lunn.ch> <20170405172224.38c1f9fb@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170405172224.38c1f9fb@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ralph Sennhauser Cc: Mark Rutland , devicetree@vger.kernel.org, Jason Cooper , linux-kernel@vger.kernel.org, Russell King , Rob Herring , Gregory Clement , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org > In fact "internet" label on the case is uppercase, would this matter > for you for new bindings, or would you still use the lowercase version? I would use lower case, just to fix with the general convention that interface names are lower case. > > I would say, this is now too late. Changing an interface name will > > break configuration scripts. We are stuck with it. > > > > If it weren't for commit cb4f71c42988 that would have been obvious for > me as well. Yes, that was not nice. But it was also very earlier in the life of 38x, so it just affected a few developers with reference boards, not real products out in the wild, as far as i remember. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755029AbdDEPwB (ORCPT ); Wed, 5 Apr 2017 11:52:01 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:46759 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752981AbdDEPuo (ORCPT ); Wed, 5 Apr 2017 11:50:44 -0400 Date: Wed, 5 Apr 2017 17:50:32 +0200 From: Andrew Lunn To: Ralph Sennhauser Cc: linux-arm-kernel@lists.infradead.org, Mark Rutland , Jason Cooper , devicetree@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Gregory Clement , Rob Herring , Sebastian Hesselbarth Subject: Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port Message-ID: <20170405155032.GL13449@lunn.ch> References: <20170405052847.326-1-ralph.sennhauser@gmail.com> <20170405142824.GB13449@lunn.ch> <20170405172224.38c1f9fb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170405172224.38c1f9fb@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > In fact "internet" label on the case is uppercase, would this matter > for you for new bindings, or would you still use the lowercase version? I would use lower case, just to fix with the general convention that interface names are lower case. > > I would say, this is now too late. Changing an interface name will > > break configuration scripts. We are stuck with it. > > > > If it weren't for commit cb4f71c42988 that would have been obvious for > me as well. Yes, that was not nice. But it was also very earlier in the life of 38x, so it just affected a few developers with reference boards, not real products out in the wild, as far as i remember. Andrew