From: Jonathan Nieder <jrnieder@gmail.com>
To: git@jeffhostetler.com
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v6] read-cache: force_verify_index_checksum
Date: Wed, 5 Apr 2017 11:41:19 -0700 [thread overview]
Message-ID: <20170405184119.GF8741@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20170405180625.12439-2-git@jeffhostetler.com>
Hi,
git@jeffhostetler.com wrote:
> --- a/t/t1450-fsck.sh
> +++ b/t/t1450-fsck.sh
> @@ -689,4 +689,17 @@ test_expect_success 'bogus head does not fallback to all heads' '
> ! grep $blob out
> '
>
> +test_expect_success 'detect corrupt index file in fsck' '
> + cp .git/index .git/index.backup &&
> + test_when_finished "mv .git/index.backup .git/index" &&
> + echo zzzzzzzz >zzzzzzzz &&
> + test_when_finished "rm zzzzzzzz" &&
> + git add zzzzzzzz &&
> + sed -e "s/zzzzzzzz/yyyyyyyy/" .git/index >.git/index.yyy &&
> + rm .git/index &&
> + mv .git/index.yyy .git/index &&
Why is the "rm" before "mv" needed? I would have expected "mv" to
replace the file.
If that doesn't work, I expect there are a large number of other tests
that would need fixing...
> + test_when_finished "rm .git/index" &&
Likewise --- this seems redundant next to the "mv" enqueued previously.
> + test_must_fail git fsck --cache
That said,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
prev parent reply other threads:[~2017-04-05 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 18:06 [PATCH v6] read-cache: call verify_hdr() in a background thread git
2017-04-05 18:06 ` [PATCH v6] read-cache: force_verify_index_checksum git
2017-04-05 18:25 ` Jeff King
2017-04-05 19:06 ` Jeff Hostetler
2017-04-05 18:41 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405184119.GF8741@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.