From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Sagar Abhang <sabhang@brocade.com>
Cc: mtetsuyah@gmail.com, dev@dpdk.org
Subject: Re: [PATCH] net/vhost: move device stop call in close function
Date: Thu, 6 Apr 2017 13:51:12 +0800 [thread overview]
Message-ID: <20170406055112.GQ18844@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1491000430-9884-1-git-send-email-sabhang@brocade.com>
On Fri, Mar 31, 2017 at 03:47:10PM -0700, Sagar Abhang wrote:
> Moved the call to "eth_dev_stop" inside "eth_dev_close" because
> "rte_eth_dev_close" calls 'close' operation of device, and in existing
> code the close was happening without 'stop' operation for vhost device.
> Moved code to free rx and tx queues inside "eth_dev_close" because the
> "rte_eth_dev_close" function calls the vhost's "eth_dev_close" function
> In that case, the memory allocated for the queues is not freed up
> before we free the pointer of rx and tx queues causing memory leak.
This patch looks Okay to me, expect the log is a bit hard to understand:
you don't have to explain that "rte_eth_dev_xx" calls the vhost "eth_dev_xxx".
Also please use whitespace lines between paragraphs.
Will you try to reword the log a bit, so that I can apply?
Thanks.
--yliu
next prev parent reply other threads:[~2017-04-06 5:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 22:47 [PATCH] net/vhost: move device stop call in close function Sagar Abhang
2017-04-06 5:51 ` Yuanhan Liu [this message]
2017-04-07 0:26 ` [PATCH v2] net/vhost: stop dev in close and address mem leak Sagar Abhang
2017-04-13 1:45 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406055112.GQ18844@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=mtetsuyah@gmail.com \
--cc=sabhang@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.