All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: generic memory addresses
Date: Thu, 6 Apr 2017 08:08:20 +0200	[thread overview]
Message-ID: <20170406060820.GA9759@kroah.com> (raw)
In-Reply-To: <20170406003101.GH18834@eros>

On Thu, Apr 06, 2017 at 10:31:01AM +1000, Tobin C. Harding wrote:
> Why is there code in-tree that declares generic memory addresses as
> unsigned int?
> 
> Linux Device Drivers 3rd Edition page 289
>  Therefore, generic memory addresses in the kernel are usually unsigned
>  long, exploiting the fact that pointers and long integers are always
>  the same size, at least on all the platforms currently supported by
>  Linux.
> 
> It would therefore seem like a bug to declare a generic memory address
> as an unsigned int in code that can run on 64 bit machines.

I agree, that does seem like a bug.

> What is the explanation for such declarations in the kernel please?
> 
> $ cd KERNEL_TREE
> $ git grep 'unsigned int addr' | wc -l
> 556

Make sure those really are being used to store a real address, sometimes
they are not...

thanks,

greg k-h

  reply	other threads:[~2017-04-06  6:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06  0:31 generic memory addresses Tobin C. Harding
2017-04-06  6:08 ` Greg KH [this message]
2017-04-06 10:11   ` Tobin C. Harding
2017-04-06 16:59     ` Greg KH
2017-04-06 22:02       ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406060820.GA9759@kroah.com \
    --to=greg@kroah.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.