All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: mreitz@redhat.com, pbonzini@redhat.com, jcody@redhat.com,
	Ciprian.Barbu@enea.com, Alexandru.Avadanii@enea.com,
	armband@enea.com, eblake@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH for-2.9] block: Ignore guest dev permissions during incoming migration
Date: Thu, 6 Apr 2017 13:15:43 +0200	[thread overview]
Message-ID: <20170406111543.GE4341@noname.redhat.com> (raw)
In-Reply-To: <1491320156-4629-1-git-send-email-kwolf@redhat.com>

Am 04.04.2017 um 17:35 hat Kevin Wolf geschrieben:
> Usually guest devices don't like other writers to the same image, so
> they use blk_set_perm() to prevent this from happening. In the migration
> phase before the VM is actually running, though, they don't have a
> problem with writes to the image. On the other hand, storage migration
> needs to be able to write to the image in this phase, so the restrictive
> blk_set_perm() call of qdev devices breaks it.
> 
> This patch flags all BlockBackends with a qdev device as
> blk->disable_perm during incoming migration, which means that the
> requested permissions are stored in the BlockBackend, but not actually
> applied to its root node yet.
> 
> Once migration has finished and the VM should be resumed, the
> permissions are applied. If they cannot be applied (e.g. because the NBD
> server used for block migration hasn't been shut down), resuming the VM
> fails.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Ciprian, can you give this patch a try and report back whether it fixes
the storage migration bug you encountered?

Kevin

  parent reply	other threads:[~2017-04-06 11:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 15:35 [Qemu-devel] [RFC PATCH for-2.9] block: Ignore guest dev permissions during incoming migration Kevin Wolf
2017-04-05 13:22 ` Max Reitz
2017-04-06 11:22   ` Kevin Wolf
2017-04-06 11:31     ` Daniel P. Berrange
2017-04-06 11:15 ` Kevin Wolf [this message]
2017-04-06 17:16 ` [Qemu-devel] [Qemu-block] " Kashyap Chamarthy
2017-04-06 17:26 ` Kashyap Chamarthy
2017-04-06 18:46   ` Kashyap Chamarthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406111543.GE4341@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=Alexandru.Avadanii@enea.com \
    --cc=Ciprian.Barbu@enea.com \
    --cc=armband@enea.com \
    --cc=eblake@redhat.com \
    --cc=jcody@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.