From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v4 10/11] drm/i915/dp: Validate cached link rate and lane count before retraining Date: Thu, 6 Apr 2017 17:31:07 +0300 Message-ID: <20170406143107.GY30290@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E3976E9A3 for ; Thu, 6 Apr 2017 14:31:12 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, dhinakaran.pandiyan@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMDYsIDIwMTcgYXQgMDQ6NDQ6MThQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gRnJvbTogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiAK PiBDdXJyZW50bHkgaW50ZWxfZHBfY2hlY2tfbGlua19zdGF0dXMoKSB0cmllcyB0byByZXRyYWlu IHRoZSBsaW5rIGlmCj4gQ2xvY2sgcmVjb3Zlcnkgb3IgQ2hhbm5lbCBFUSBmb3IgYW55IG9mIHRo ZSBsYW5lcyBpbmRpY2F0ZWQgYnkKPiBpbnRlbF9kcC0+bGFuZV9jb3VudCBpcyBub3Qgc2V0LiBI b3dldmVyIHRoZXNlIHZhbHVlcyBjYWNoZWQgaW4gaW50ZWxfZHAKPiBzdHJ1Y3R1cmUgY2FuIGJl IHN0YWxlIGlmIGxpbmsgdHJhaW5pbmcgaGFzIGZhaWxlZCBmb3IgdGhlc2UgdmFsdWVzCj4gZHVy aW5nIHByZXZpb3VzIG1vZGVzZXQuIE9yIHRoZXNlIHZhbHVlcyBjYW4gZ2V0IHN0YWxlIHNpbmNl IHdlIGhhdmUKPiBub3cgcmUgcmVhZCB0aGUgRFBDRCByZWdpc3RlcnMgb3IgaXQgY2FuIGJlIDAg aW4gY2FzZSBvZiBjb25uZWN0ZWQgYm9vdAo+IGNhc2UuCj4gCj4gVGhpcyBwYXRjaCB2YWxpZGF0 ZXMgdGhlc2UgdmFsdWVzIGFnYWluc3QgdGhlIGNvbW1vbl9yYXRlcyBhbmQgbWF4IGxhbmUKPiBj b3VudCB2YWx1ZXMuCj4gCj4gVGhpcyBpcyBhYnNvbHV0ZWx5IHJlcXVpcmVkIGluY2FzZSB0aGUg Y29tbW9uX3JhdGVzIG9yIG1heCBsYW5lIGNvdW50Cj4gYXJlIG5vdyBkaWZmZXJlbnQgZHVlIHRv IGxpbmsgZmFsbGJhY2suCj4gCj4gdjI6Cj4gKiBJbmNsdWRlIHRoZSBGSVhNRSBjb21tbmV0IGlu c2lkZSB0aGUgZnVuY3Rpb24gKFZpbGxlIFN5cmphbGEpCj4gKiBSZW1vdmUgdGhlIHJlZHVuZGFu dCBwYXJlbnRoZXNpcyAoVmlsbGUgU3lyamFsYSkKPiAKPiB2MyBieSBKYW5pOgo+ICogcmViYXNl IG9uIHRoZSBEUCByZWZhY3RvcmluZyBzZXJpZXMKPiAqIHJlbmFtZSBpbnRlbF9kcF9saW5rX3Bh cmFtc19pc192YWxpZCB0byBpbnRlbF9kcF9saW5rX3BhcmFtc192YWxpZAo+ICogbWlub3Igc3R5 bGlzdGljIGNoYW5nZXMKPiAKPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5j b20+Cj4gU2lnbmVkLW9mZi1ieTogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVs LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgMzAgKysrKysrKysr KysrKysrKysrKysrKysrKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCsp LCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDNjNWM4 MGRhOWVhMy4uNjkxNWQ4OWEyMzhjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAg LTMyMiw2ICszMjIsMjggQEAgc3RhdGljIGludCBpbnRlbF9kcF9jb21tb25fbGVuX3JhdGVfbGlt aXQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+ICtz dGF0aWMgYm9vbCBpbnRlbF9kcF9saW5rX3BhcmFtc192YWxpZChzdHJ1Y3QgaW50ZWxfZHAgKmlu dGVsX2RwKQo+ICt7Cj4gKwlpbnQgaW5kZXg7Cj4gKwo+ICsJLyoKPiArCSAqIEZJWE1FOiB3ZSBu ZWVkIHRvIHN5bmNocm9uaXplIHRoZSBjdXJyZW50IGxpbmsgcGFyYW1ldGVycyB3aXRoCj4gKwkg KiBoYXJkd2FyZSByZWFkb3V0LiBDdXJyZW50bHkgZmFzdCBsaW5rIHRyYWluaW5nIGRvZXNuJ3Qg d29yayBvbgo+ICsJICogYm9vdC11cC4KPiArCSAqLwo+ICsJaW5kZXggPSBpbnRlbF9kcF9yYXRl X2luZGV4KGludGVsX2RwLT5jb21tb25fcmF0ZXMsCj4gKwkJCQkgICAgaW50ZWxfZHAtPm51bV9j b21tb25fcmF0ZXMsCj4gKwkJCQkgICAgaW50ZWxfZHAtPmxpbmtfcmF0ZSk7Cj4gKwlpZiAoaW5k ZXggPCAwKQo+ICsJCXJldHVybiBmYWxzZTsKCkhtbS4gSXNuJ3QgY29tbW9uX3JhdGVzW10gc3Rp bGwganVzdCB0aGUgaW50ZXJzZWN0aW9uIG9mIHRoZSBzb3VyY2UKYW5kIHNpbmsgcmF0ZXM/IFNv IGl0IGxvb2tzIHRvIG1lIGxpa2UgdGhpcyBzaG91bGQgYWN0dWFsbHkganVzdCBjaGVjawpmb3Ig J2xpbmtfcmF0ZSA9PSAwIHx8IGxpbmtfcmF0ZSA+IG1heF9saW5rX3JhdGUnLCBvciBzb21ldGhp bmcgc2ltaWxhci4KCj4gKwo+ICsJaWYgKGludGVsX2RwLT5sYW5lX2NvdW50ID09IDAgfHwKPiAr CSAgICBpbnRlbF9kcC0+bGFuZV9jb3VudCA+IGludGVsX2RwX21heF9sYW5lX2NvdW50KGludGVs X2RwKSkKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwo+ICsJcmV0dXJuIHRydWU7Cj4gK30KPiArCj4g IGludCBpbnRlbF9kcF9nZXRfbGlua190cmFpbl9mYWxsYmFja192YWx1ZXMoc3RydWN0IGludGVs X2RwICppbnRlbF9kcCwKPiAgCQkJCQkgICAgaW50IGxpbmtfcmF0ZSwgdWludDhfdCBsYW5lX2Nv dW50KQo+ICB7Cj4gQEAgLTQyNTMsOSArNDI3NSwxMSBAQCBpbnRlbF9kcF9jaGVja19saW5rX3N0 YXR1cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJaWYgKCF0b19pbnRlbF9jcnRjKGlu dGVsX2VuY29kZXItPmJhc2UuY3J0YyktPmFjdGl2ZSkKPiAgCQlyZXR1cm47Cj4gIAo+IC0JLyog RklYTUU6IHdlIG5lZWQgdG8gc3luY2hyb25pemUgdGhpcyBzb3J0IG9mIHN0dWZmIHdpdGggaGFy ZHdhcmUKPiAtCSAqIHJlYWRvdXQuIEN1cnJlbnRseSBmYXN0IGxpbmsgdHJhaW5pbmcgZG9lc24n dCB3b3JrIG9uIGJvb3QtdXAuICovCj4gLQlpZiAoIWludGVsX2RwLT5sYW5lX2NvdW50KQo+ICsJ LyoKPiArCSAqIFZhbGlkYXRlIHRoZSBjYWNoZWQgdmFsdWVzIG9mIGludGVsX2RwLT5saW5rX3Jh dGUgYW5kCj4gKwkgKiBpbnRlbF9kcC0+bGFuZV9jb3VudCBiZWZvcmUgYXR0ZW1wdGluZyB0byBy ZXRyYWluLgo+ICsJICovCj4gKwlpZiAoIWludGVsX2RwX2xpbmtfcGFyYW1zX3ZhbGlkKGludGVs X2RwKSkKPiAgCQlyZXR1cm47Cj4gIAo+ICAJLyogUmV0cmFpbiBpZiBDaGFubmVsIEVRIG9yIENS IG5vdCBvayAqLwo+IC0tIAo+IDIuMS40CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK