From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Move the GTFIFODBG to the
 common mmio dbg framework
Date: Thu, 6 Apr 2017 18:46:29 +0300
Message-ID: <20170406154629.GZ30290@intel.com>
References: <20170406091433.GZ10496@nuc-i3427.alporthouse.com>
 <1491493182-31540-1-git-send-email-mika.kuoppala@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 78F306E9C2
 for <intel-gfx@lists.freedesktop.org>; Thu,  6 Apr 2017 15:46:49 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1491493182-31540-1-git-send-email-mika.kuoppala@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBBcHIgMDYsIDIwMTcgYXQgMDY6Mzk6NDJQTSArMDMwMCwgTWlrYSBLdW9wcGFsYSB3
cm90ZToKPiBSZW1vdmUgdGhlIHBlci1tbWlvIGNoZWNraW5nIG9mIHRoZSBGSUZPIGRlYnVnIHJl
Z2lzdGVyIGludG8gdGhlIGNvbW1vbgo+IGNvbmRpdGlvbmFsIG1taW8gZGVidWcgaGFuZGxpbmcu
IEJhc2VkIG9uIHBhdGNoIGZyb20gQ2hyaXMgV2lsc29uLgo+IAo+IHYyOiBwb3N0cG9uZSB3YXJu
IG9uIGZpZm9kYmcgZm9yIHVuY2xhaW1lZCByZWcgZGVidWdzCj4gCj4gU2lnbmVkLW9mZi1ieTog
TWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IENo
cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICBkcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYyB8IDc2ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDQ2IGRlbGV0
aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNv
cmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4gaW5kZXggNmQxZWEy
Ni4uN2E4ZWIyZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNv
cmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4gQEAgLTE3
MiwyMiArMTcyLDYgQEAgc3RhdGljIHZvaWQgZndfZG9tYWluc19nZXRfd2l0aF90aHJlYWRfc3Rh
dHVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCV9fZ2VuNl9ndF93YWl0
X2Zvcl90aHJlYWRfYzAoZGV2X3ByaXYpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBnZW42X2d0
X2NoZWNrX2ZpZm9kYmcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+IC17Cj4g
LQl1MzIgZ3RmaWZvZGJnOwo+IC0KPiAtCWd0Zmlmb2RiZyA9IF9fcmF3X2k5MTVfcmVhZDMyKGRl
dl9wcml2LCBHVEZJRk9EQkcpOwo+IC0JaWYgKFdBUk4oZ3RmaWZvZGJnLCAiR1Qgd2FrZSBGSUZP
IGVycm9yIDB4JXhcbiIsIGd0Zmlmb2RiZykpCj4gLQkJX19yYXdfaTkxNV93cml0ZTMyKGRldl9w
cml2LCBHVEZJRk9EQkcsIGd0Zmlmb2RiZyk7Cj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lkIGZ3X2Rv
bWFpbnNfcHV0X3dpdGhfZmlmbyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g
LQkJCQkgICAgIGVudW0gZm9yY2V3YWtlX2RvbWFpbnMgZndfZG9tYWlucykKPiAtewo+IC0JZndf
ZG9tYWluc19wdXQoZGV2X3ByaXYsIGZ3X2RvbWFpbnMpOwo+IC0JZ2VuNl9ndF9jaGVja19maWZv
ZGJnKGRldl9wcml2KTsKPiAtfQo+IC0KPiAgc3RhdGljIGlubGluZSB1MzIgZmlmb19mcmVlX2Vu
dHJpZXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gIAl1MzIgY291
bnQgPSBfX3Jhd19pOTE1X3JlYWQzMihkZXZfcHJpdiwgR1RGSUZPQ1RMKTsKPiBAQCAtMzg0LDE1
ICszNjgsMzUgQEAgdmx2X2NoZWNrX2Zvcl91bmNsYWltZWRfbW1pbyhzdHJ1Y3QgZHJtX2k5MTVf
cHJpdmF0ZSAqZGV2X3ByaXYpCj4gIH0KPiAgCj4gIHN0YXRpYyBib29sCj4gK2dlbjZfY2hlY2tf
Zm9yX2ZpZm9fZGVidWcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4g
Kwl1MzIgZmlmb2RiZzsKPiArCj4gKwlmaWZvZGJnID0gX19yYXdfaTkxNV9yZWFkMzIoZGV2X3By
aXYsIEdURklGT0RCRyk7Cj4gKwo+ICsJaWYgKHVubGlrZWx5KGZpZm9kYmcpKSB7Cj4gKwkJRFJN
X0RFQlVHX0RSSVZFUigiR1RGSUZPREJHID0gMHgwOCV4XG4iLCBmaWZvZGJnKTsKPiArCQlfX3Jh
d19pOTE1X3dyaXRlMzIoZGV2X3ByaXYsIEdURklGT0RCRywgZmlmb2RiZyk7Cj4gKwl9Cj4gKwo+
ICsJcmV0dXJuIGZpZm9kYmc7Cj4gK30KPiArCj4gK3N0YXRpYyBib29sCj4gIGNoZWNrX2Zvcl91
bmNsYWltZWRfbW1pbyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAr
CWJvb2wgcmV0ID0gZmFsc2U7Cj4gKwo+ICAJaWYgKEhBU19GUEdBX0RCR19VTkNMQUlNRUQoZGV2
X3ByaXYpKQo+IC0JCXJldHVybiBmcGdhX2NoZWNrX2Zvcl91bmNsYWltZWRfbW1pbyhkZXZfcHJp
dik7Cj4gKwkJcmV0IHw9IGZwZ2FfY2hlY2tfZm9yX3VuY2xhaW1lZF9tbWlvKGRldl9wcml2KTsK
PiAgCj4gIAlpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklFVyhkZXZf
cHJpdikpCj4gLQkJcmV0dXJuIHZsdl9jaGVja19mb3JfdW5jbGFpbWVkX21taW8oZGV2X3ByaXYp
Owo+ICsJCXJldCB8PSB2bHZfY2hlY2tfZm9yX3VuY2xhaW1lZF9tbWlvKGRldl9wcml2KTsKPiAg
Cj4gLQlyZXR1cm4gZmFsc2U7Cj4gKwlpZiAoSVNfR0VONihkZXZfcHJpdikgfHwgSVNfR0VONyhk
ZXZfcHJpdikpCj4gKwkJcmV0IHw9IGdlbjZfY2hlY2tfZm9yX2ZpZm9fZGVidWcoZGV2X3ByaXYp
OwoKSSdkIHByZWZlciB0byBrZWVwIHVuY2xhaW0gdnMuIHdha2UgRklGTyBzZXBhcmF0ZSBiZWNh
dXNlIHRoZQp1bmNsYWltbmVkIHN0dWZmIGlzIG9ubHkgZm9yIGRpc3BsYXkgcmVnaXN0ZXJzLiBJ
biBteSBwbGFuIHRvCnNwbGl0IHRoZSB1bmNvcmUgbG9jayBpbnRvIGd0IGFuZCBkaXNwbGF5IGxv
Y2tzIHRoZSB1bmNsYWltZWQKcmVnIHN0dWZmIHdvdWxkIGVuZCB1cCBiZWluZyBwcm90ZWN0ZWQg
YnkgdGhlIGRpc3BsYXkgbG9jayByYXRoZXIKdGhhbiB0aGUgZ3QgbG9jay4KCj4gKwo+ICsJcmV0
dXJuIHJldDsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgX19pbnRlbF91bmNvcmVfZWFybHlfc2Fu
aXRpemUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IEBAIC00MDQsMTEgKzQw
OCw2IEBAIHN0YXRpYyB2b2lkIF9faW50ZWxfdW5jb3JlX2Vhcmx5X3Nhbml0aXplKHN0cnVjdCBk
cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCWlmIChjaGVja19mb3JfdW5jbGFpbWVkX21t
aW8oZGV2X3ByaXYpKQo+ICAJCURSTV9ERUJVRygidW5jbGFpbWVkIG1taW8gZGV0ZWN0ZWQgb24g
dW5jb3JlIGluaXQsIGNsZWFyaW5nXG4iKTsKPiAgCj4gLQkvKiBjbGVhciBvdXQgb2xkIEdUIEZJ
Rk8gZXJyb3JzICovCj4gLQlpZiAoSVNfR0VONihkZXZfcHJpdikgfHwgSVNfR0VONyhkZXZfcHJp
dikpCj4gLQkJX19yYXdfaTkxNV93cml0ZTMyKGRldl9wcml2LCBHVEZJRk9EQkcsCj4gLQkJCQkg
ICBfX3Jhd19pOTE1X3JlYWQzMihkZXZfcHJpdiwgR1RGSUZPREJHKSk7Cj4gLQo+ICAJLyogV2FE
aXNhYmxlU2hhZG93UmVnRm9yQ3BkOmNodiAqLwo+ICAJaWYgKElTX0NIRVJSWVZJRVcoZGV2X3By
aXYpKSB7Cj4gIAkJX19yYXdfaTkxNV93cml0ZTMyKGRldl9wcml2LCBHVEZJRk9DVEwsCj4gQEAg
LTEwNDcsMTUgKzEwNDYsMTAgQEAgX19nZW4yX3dyaXRlKDMyKQo+ICAjZGVmaW5lIF9fZ2VuNl93
cml0ZSh4KSBcCj4gIHN0YXRpYyB2b2lkIFwKPiAgZ2VuNl93cml0ZSMjeChzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGk5MTVfcmVnX3QgcmVnLCB1IyN4IHZhbCwgYm9vbCB0cmFj
ZSkgeyBcCj4gLQl1MzIgX19maWZvX3JldCA9IDA7IFwKPiAgCUdFTjZfV1JJVEVfSEVBREVSOyBc
Cj4gLQlpZiAoTkVFRFNfRk9SQ0VfV0FLRShvZmZzZXQpKSB7IFwKPiAtCQlfX2ZpZm9fcmV0ID0g
X19nZW42X2d0X3dhaXRfZm9yX2ZpZm8oZGV2X3ByaXYpOyBcCj4gLQl9IFwKPiArCWlmIChORUVE
U19GT1JDRV9XQUtFKG9mZnNldCkpIFwKPiArCQlfX2dlbjZfZ3Rfd2FpdF9mb3JfZmlmbyhkZXZf
cHJpdik7IFwKPiAgCV9fcmF3X2k5MTVfd3JpdGUjI3goZGV2X3ByaXYsIHJlZywgdmFsKTsgXAo+
IC0JaWYgKHVubGlrZWx5KF9fZmlmb19yZXQpKSB7IFwKPiAtCQlnZW42X2d0X2NoZWNrX2ZpZm9k
YmcoZGV2X3ByaXYpOyBcCj4gLQl9IFwKPiAgCUdFTjZfV1JJVEVfRk9PVEVSOyBcCj4gIH0KPiAg
Cj4gQEAgLTExOTAsMTEgKzExODQsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF91bmNvcmVfZndfZG9t
YWluc19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQkJICAgICAg
IEZPUkNFV0FLRV9NRURJQV9HRU45LCBGT1JDRVdBS0VfQUNLX01FRElBX0dFTjkpOwo+ICAJfSBl
bHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2
KSkgewo+ICAJCWRldl9wcml2LT51bmNvcmUuZnVuY3MuZm9yY2Vfd2FrZV9nZXQgPSBmd19kb21h
aW5zX2dldDsKPiAtCQlpZiAoIUlTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+IC0JCQlkZXZfcHJp
di0+dW5jb3JlLmZ1bmNzLmZvcmNlX3dha2VfcHV0ID0KPiAtCQkJCWZ3X2RvbWFpbnNfcHV0X3dp
dGhfZmlmbzsKPiAtCQllbHNlCj4gLQkJCWRldl9wcml2LT51bmNvcmUuZnVuY3MuZm9yY2Vfd2Fr
ZV9wdXQgPSBmd19kb21haW5zX3B1dDsKPiArCQlkZXZfcHJpdi0+dW5jb3JlLmZ1bmNzLmZvcmNl
X3dha2VfcHV0ID0gZndfZG9tYWluc19wdXQ7Cj4gIAkJZndfZG9tYWluX2luaXQoZGV2X3ByaXYs
IEZXX0RPTUFJTl9JRF9SRU5ERVIsCj4gIAkJCSAgICAgICBGT1JDRVdBS0VfVkxWLCBGT1JDRVdB
S0VfQUNLX1ZMVik7Cj4gIAkJZndfZG9tYWluX2luaXQoZGV2X3ByaXYsIEZXX0RPTUFJTl9JRF9N
RURJQSwKPiBAQCAtMTIwMiwxMSArMTE5Miw3IEBAIHN0YXRpYyB2b2lkIGludGVsX3VuY29yZV9m
d19kb21haW5zX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJfSBl
bHNlIGlmIChJU19IQVNXRUxMKGRldl9wcml2KSB8fCBJU19CUk9BRFdFTEwoZGV2X3ByaXYpKSB7
Cj4gIAkJZGV2X3ByaXYtPnVuY29yZS5mdW5jcy5mb3JjZV93YWtlX2dldCA9Cj4gIAkJCWZ3X2Rv
bWFpbnNfZ2V0X3dpdGhfdGhyZWFkX3N0YXR1czsKPiAtCQlpZiAoSVNfSEFTV0VMTChkZXZfcHJp
dikpCj4gLQkJCWRldl9wcml2LT51bmNvcmUuZnVuY3MuZm9yY2Vfd2FrZV9wdXQgPQo+IC0JCQkJ
ZndfZG9tYWluc19wdXRfd2l0aF9maWZvOwo+IC0JCWVsc2UKPiAtCQkJZGV2X3ByaXYtPnVuY29y
ZS5mdW5jcy5mb3JjZV93YWtlX3B1dCA9IGZ3X2RvbWFpbnNfcHV0Owo+ICsJCWRldl9wcml2LT51
bmNvcmUuZnVuY3MuZm9yY2Vfd2FrZV9wdXQgPSBmd19kb21haW5zX3B1dDsKPiAgCQlmd19kb21h
aW5faW5pdChkZXZfcHJpdiwgRldfRE9NQUlOX0lEX1JFTkRFUiwKPiAgCQkJICAgICAgIEZPUkNF
V0FLRV9NVCwgRk9SQ0VXQUtFX0FDS19IU1cpOwo+ICAJfSBlbHNlIGlmIChJU19JVllCUklER0Uo
ZGV2X3ByaXYpKSB7Cj4gQEAgLTEyMjMsOCArMTIwOSw3IEBAIHN0YXRpYyB2b2lkIGludGVsX3Vu
Y29yZV9md19kb21haW5zX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+
ICAJCSAqLwo+ICAJCWRldl9wcml2LT51bmNvcmUuZnVuY3MuZm9yY2Vfd2FrZV9nZXQgPQo+ICAJ
CQlmd19kb21haW5zX2dldF93aXRoX3RocmVhZF9zdGF0dXM7Cj4gLQkJZGV2X3ByaXYtPnVuY29y
ZS5mdW5jcy5mb3JjZV93YWtlX3B1dCA9Cj4gLQkJCWZ3X2RvbWFpbnNfcHV0X3dpdGhfZmlmbzsK
PiArCQlkZXZfcHJpdi0+dW5jb3JlLmZ1bmNzLmZvcmNlX3dha2VfcHV0ID0gZndfZG9tYWluc19w
dXQ7Cj4gIAo+ICAJCS8qIFdlIG5lZWQgdG8gaW5pdCBmaXJzdCBmb3IgRUNPQlVTIGFjY2VzcyBh
bmQgdGhlbgo+ICAJCSAqIGRldGVybWluZSBsYXRlciBpZiB3ZSB3YW50IHRvIHJlaW5pdCwgaW4g
Y2FzZSBvZiBNVCBhY2Nlc3MgaXMKPiBAQCAtMTI0Miw3ICsxMjI3LDcgQEAgc3RhdGljIHZvaWQg
aW50ZWxfdW5jb3JlX2Z3X2RvbWFpbnNfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2
X3ByaXYpCj4gIAkJc3Bpbl9sb2NrX2lycSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrKTsKPiAgCQlm
d19kb21haW5zX2dldF93aXRoX3RocmVhZF9zdGF0dXMoZGV2X3ByaXYsIEZPUkNFV0FLRV9SRU5E
RVIpOwo+ICAJCWVjb2J1cyA9IF9fcmF3X2k5MTVfcmVhZDMyKGRldl9wcml2LCBFQ09CVVMpOwo+
IC0JCWZ3X2RvbWFpbnNfcHV0X3dpdGhfZmlmbyhkZXZfcHJpdiwgRk9SQ0VXQUtFX1JFTkRFUik7
Cj4gKwkJZndfZG9tYWluc19wdXQoZGV2X3ByaXYsIEZPUkNFV0FLRV9SRU5ERVIpOwo+ICAJCXNw
aW5fdW5sb2NrX2lycSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrKTsKPiAgCj4gIAkJaWYgKCEoZWNv
YnVzICYgRk9SQ0VXQUtFX01UX0VOQUJMRSkpIHsKPiBAQCAtMTI1NCw4ICsxMjM5LDcgQEAgc3Rh
dGljIHZvaWQgaW50ZWxfdW5jb3JlX2Z3X2RvbWFpbnNfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYpCj4gIAl9IGVsc2UgaWYgKElTX0dFTjYoZGV2X3ByaXYpKSB7Cj4gIAkJ
ZGV2X3ByaXYtPnVuY29yZS5mdW5jcy5mb3JjZV93YWtlX2dldCA9Cj4gIAkJCWZ3X2RvbWFpbnNf
Z2V0X3dpdGhfdGhyZWFkX3N0YXR1czsKPiAtCQlkZXZfcHJpdi0+dW5jb3JlLmZ1bmNzLmZvcmNl
X3dha2VfcHV0ID0KPiAtCQkJZndfZG9tYWluc19wdXRfd2l0aF9maWZvOwo+ICsJCWRldl9wcml2
LT51bmNvcmUuZnVuY3MuZm9yY2Vfd2FrZV9wdXQgPSBmd19kb21haW5zX3B1dDsKPiAgCQlmd19k
b21haW5faW5pdChkZXZfcHJpdiwgRldfRE9NQUlOX0lEX1JFTkRFUiwKPiAgCQkJICAgICAgIEZP
UkNFV0FLRSwgRk9SQ0VXQUtFX0FDSyk7Cj4gIAl9Cj4gLS0gCj4gMi43LjQKPiAKPiBfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWls
aW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBT
eXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr
dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu
dGVsLWdmeAo=