From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot Date: Thu, 6 Apr 2017 10:55:57 -0600 Message-ID: <20170406165557.GD7657@obsidianresearch.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Paul Menzel Cc: "Maciej S. Szmigiero" , tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, GNUtoo-n+LsquliYkMdnm+yROfE0A@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net T24gVGh1LCBBcHIgMDYsIDIwMTcgYXQgMDg6MTg6MzNBTSArMDIwMCwgUGF1bCBNZW56ZWwgd3Jv dGU6Cgo+IEluZGVlZCwgdGhhdCBpbXByb3ZlcyB0aGUgc2l0dWF0aW9uLiBJIHN0aWxsIG5lZWQg dG8gcGFzcyBgZm9yY2U9MWAgdG8gdGhlCj4gbW9kdWxlIHRvIGdldCBgL2Rldi90cG0wYC4gTm8g aWRlYSwgd2h5IGl04oCZcyBub3QgaW4gaW5jbHVkZWQgaW4gTGludXggNC45Cj4geWV0LgoKRmFp ciBwb2ludC4uIEphcmtrbyAtIGNvdWxkIHlvdSBmb3J3YXJkIHRoYXQgcGF0Y2ggdG8gLXN0YWJs ZT8KCj4gJCBqb3VybmFsY3RsIC1rIC1vIGNhdCB8IGdyZXAgdHBtCj4gdHBtX3RpcyB0cG1fdGlz OiAxLjIgVFBNIChkZXZpY2UtaWQgMHgzMjAyLCByZXYtaWQgNSkKPiB0cG0gdHBtMDogSXNzdWlu ZyBUUE1fU1RBUlRVUAo+IHRwbSB0cG0wOiBbSGFyZHdhcmUgRXJyb3JdOiBBZGp1c3RpbmcgcmVw b3J0ZWQgdGltZW91dHM6IEEgMTAwMDAtPjEwMDAwdXMgQgo+IDEwMDAwLT4xMDAwMHVzIEMgMC0+ NzUyMDAwdXMgRCAwLT43NTIwMDB1cwoKVGhlcmUgY291bGQgYmUgbW9yZSByZWxhdmVudCBrZXJu ZWwgbWVzc2FnZXMgdGhhbiB0aGlzLCB0cnkKICBncmVwIC1pIHRwbQoKPwoKPiBTbyBkbyB5b3Ug aGF2ZSBhbiBpZGVhLCB3aGF0IOKAnEFDUEkgcmVxdWlyZW1lbnRz4oCdIGNoYW5nZWQgaW4gdGhl IGB0cG1gIG1vZHVsZQo+IHNpbmNlIExpbnV4IDMuMTYgdG8gYmUgbG9hZGVkIGF1dG9tYXRpY2Fs bHk/CgpXZSBhZGRlZCBkaXJlY3QgQUNQSSBiaW5kaW5nIHRvIHRoZSBkcml2ZXIgaW4gYWRkaXRp b24gdG8gUE5QLCBzbyBpZgp5b3UgaGF2ZSBhbiBBQ1BJIHRhYmxlIGl0IGdvZXMgZG93biB0aGF0 IHBhdGggYW5kIGRvZXMgc29tZSBhZGRpdGlvbmFsCnZhbGlkYXRpb24gb2Ygd2hhdCBpcyBpbiB0 aGUgVFBNLiBUaGUgQklPUyBtdXN0IHByb3ZpZGUgYQphY3BpX2Rldl9yZXNvdXJjZV9tZW1vcnkg YW5kIGEgQUNQSV9TSUdfVFBNMiBmb3IgdGhlIEFDUEkgZW50cnkgYXQgYQptaW5pbXVtLgoKVGhl cmUgYXJlIEZXX0JVRyBwcmludHMgaWYgdGhvc2UgZmFpbCwgc28gY2hlY2sgeW91ciBkbWVzZyBj bG9zZWx5PwoKaHR0cDovL2x4ci5mcmVlLWVsZWN0cm9ucy5jb20vc291cmNlL2RyaXZlcnMvY2hh ci90cG0vdHBtX3Rpcy5jI0wyNTAKCklmIG5vdCwgY2FuIHlvdSBhbm5vdGF0ZSBpbiBzb21lIHBy aW50aydzIGludG8gdHBtX3Rpc19hY3BpX2luaXQgYW5kCnJlY29tcGlsZS9yZS10ZXN0PwoKSmFz b24KCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpDaGVjayBvdXQgdGhlIHZpYnJhbnQgdGVjaCBjb21t dW5pdHkgb24gb25lIG9mIHRoZSB3b3JsZCdzIG1vc3QKZW5nYWdpbmcgdGVjaCBzaXRlcywgU2xh c2hkb3Qub3JnISBodHRwOi8vc2RtLmxpbmsvc2xhc2hkb3QKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KdHBtZGQtZGV2ZWwgbWFpbGluZyBsaXN0CnRwbWRk LWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5l dC9saXN0cy9saXN0aW5mby90cG1kZC1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755574AbdDFQ4V (ORCPT ); Thu, 6 Apr 2017 12:56:21 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:45012 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754781AbdDFQ4M (ORCPT ); Thu, 6 Apr 2017 12:56:12 -0400 Date: Thu, 6 Apr 2017 10:55:57 -0600 From: Jason Gunthorpe To: Paul Menzel Cc: "Maciej S. Szmigiero" , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, GNUtoo@no-log.org Subject: Re: [tpmdd-devel] Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot Message-ID: <20170406165557.GD7657@obsidianresearch.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 06, 2017 at 08:18:33AM +0200, Paul Menzel wrote: > Indeed, that improves the situation. I still need to pass `force=1` to the > module to get `/dev/tpm0`. No idea, why it’s not in included in Linux 4.9 > yet. Fair point.. Jarkko - could you forward that patch to -stable? > $ journalctl -k -o cat | grep tpm > tpm_tis tpm_tis: 1.2 TPM (device-id 0x3202, rev-id 5) > tpm tpm0: Issuing TPM_STARTUP > tpm tpm0: [Hardware Error]: Adjusting reported timeouts: A 10000->10000us B > 10000->10000us C 0->752000us D 0->752000us There could be more relavent kernel messages than this, try grep -i tpm ? > So do you have an idea, what “ACPI requirements” changed in the `tpm` module > since Linux 3.16 to be loaded automatically? We added direct ACPI binding to the driver in addition to PNP, so if you have an ACPI table it goes down that path and does some additional validation of what is in the TPM. The BIOS must provide a acpi_dev_resource_memory and a ACPI_SIG_TPM2 for the ACPI entry at a minimum. There are FW_BUG prints if those fail, so check your dmesg closely? http://lxr.free-electrons.com/source/drivers/char/tpm/tpm_tis.c#L250 If not, can you annotate in some printk's into tpm_tis_acpi_init and recompile/re-test? Jason