From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Denis Plotnikov <dplotnikov@virtuozzo.com>
Cc: pbonzini@redhat.com, mtosatti@redhat.com, kvm@vger.kernel.org,
rkagan@virtuozzo.com, den@virtuozzo.com
Subject: Re: [PATCH 2/2] KVM: x86: fix maintaining of kvm_clock stability on guest CPU hotplug
Date: Thu, 6 Apr 2017 19:25:13 +0200 [thread overview]
Message-ID: <20170406172512.GA23559@potion> (raw)
In-Reply-To: <20170406171120.GK6369@potion>
2017-04-06 19:11+0200, Radim Krčmář:
> 2017-04-06 11:08+0300, Denis Plotnikov:
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> @@ -1455,15 +1455,23 @@ void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr)
>> elapsed = ns - kvm->arch.last_tsc_nsec;
>>
>> if (vcpu->arch.virtual_tsc_khz) {
>> - u64 tsc_exp = kvm->arch.last_tsc_write +
>> - nsec_to_cycles(vcpu, elapsed);
>> - u64 tsc_hz = vcpu->arch.virtual_tsc_khz * 1000LL;
>> - /*
>> - * Special case: TSC write with a small delta (1 second) of virtual
>> - * cycle time against real time is interpreted as an attempt to
>> - * synchronize the CPU.
>> - */
>> - synchronizing = data < tsc_exp + tsc_hz && data > tsc_exp - tsc_hz;
>> + if ((data == 0) && msr->host_initiated) {
And while I'm nitpicking ... the code would also be nicer without the
parentheses around data.
next prev parent reply other threads:[~2017-04-06 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 8:08 [PATCH 0/2] maintaining of kvm_clock stability on guest vCPU hotplug Denis Plotnikov
2017-04-06 8:08 ` [PATCH 1/2] KVM: x86: remaster kvm_write_tsc code Denis Plotnikov
2017-04-06 17:07 ` Radim Krčmář
2017-04-06 8:08 ` [PATCH 2/2] KVM: x86: fix maintaining of kvm_clock stability on guest CPU hotplug Denis Plotnikov
2017-04-06 17:11 ` Radim Krčmář
2017-04-06 17:25 ` Radim Krčmář [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-04-07 9:06 [PATCH v2 0/2] maintaining of kvm_clock stability on guest vCPU hotplug Denis Plotnikov
2017-04-07 9:06 ` [PATCH 2/2] KVM: x86: fix maintaining of kvm_clock stability on guest CPU hotplug Denis Plotnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406172512.GA23559@potion \
--to=rkrcmar@redhat.com \
--cc=den@virtuozzo.com \
--cc=dplotnikov@virtuozzo.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.