From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: [PATCH 07/25] virtio_blk: don't use req->errors Date: Thu, 6 Apr 2017 20:55:42 +0200 Message-ID: <20170406185541.GE8673@linux-x5ow.site> References: <20170406153944.10058-1-hch@lst.de> <20170406153944.10058-8-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20170406153944.10058-8-hch@lst.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Christoph Hellwig Cc: Jens Axboe , linux-scsi@vger.kernel.org, Konrad Rzeszutek Wilk , Josef Bacik , James Smart , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, dm-devel@redhat.com, Roger Pau =?iso-8859-1?Q?Monn=E9?= List-Id: dm-devel.ids On Thu, Apr 06, 2017 at 05:39:26PM +0200, Christoph Hellwig wrote: > Remove passing req->errors (which at that point is always 0) to > blk_mq_complete_requestq, and rely on the virtio status code for the blk_mq_complete_request ^ > serial number passthrough request. > = > Signed-off-by: Christoph Hellwig > --- Otherwise looks good, Reviewed-by: Johannes Thumshirn -- = Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton HRB 21284 (AG N=FCrnberg) Key fingerprint =3D EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 6 Apr 2017 20:55:42 +0200 From: Johannes Thumshirn To: Christoph Hellwig Cc: Jens Axboe , Josef Bacik , James Smart , Konrad Rzeszutek Wilk , Roger Pau =?iso-8859-1?Q?Monn=E9?= , linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, dm-devel@redhat.com Subject: Re: [PATCH 07/25] virtio_blk: don't use req->errors Message-ID: <20170406185541.GE8673@linux-x5ow.site> References: <20170406153944.10058-1-hch@lst.de> <20170406153944.10058-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <20170406153944.10058-8-hch@lst.de> List-ID: On Thu, Apr 06, 2017 at 05:39:26PM +0200, Christoph Hellwig wrote: > Remove passing req->errors (which at that point is always 0) to > blk_mq_complete_requestq, and rely on the virtio status code for the blk_mq_complete_request ^ > serial number passthrough request. > > Signed-off-by: Christoph Hellwig > --- Otherwise looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: Felix Imend�rffer, Jane Smithard, Graham Norton HRB 21284 (AG N�rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 From mboxrd@z Thu Jan 1 00:00:00 1970 From: jthumshirn@suse.de (Johannes Thumshirn) Date: Thu, 6 Apr 2017 20:55:42 +0200 Subject: [PATCH 07/25] virtio_blk: don't use req->errors In-Reply-To: <20170406153944.10058-8-hch@lst.de> References: <20170406153944.10058-1-hch@lst.de> <20170406153944.10058-8-hch@lst.de> Message-ID: <20170406185541.GE8673@linux-x5ow.site> On Thu, Apr 06, 2017@05:39:26PM +0200, Christoph Hellwig wrote: > Remove passing req->errors (which at that point is always 0) to > blk_mq_complete_requestq, and rely on the virtio status code for the blk_mq_complete_request ^ > serial number passthrough request. > > Signed-off-by: Christoph Hellwig > --- Otherwise looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn at suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850