From: Pablo Neira Ayuso <pablo@netfilter.org>
To: gfree.wind@foxmail.com
Cc: netfilter-devel@vger.kernel.org, Gao Feng <fgao@ikuai8.com>
Subject: Re: [PATCH nf-next v2 1/1] netfilter: nat: Correct the return value check for nat mangled packet
Date: Thu, 6 Apr 2017 21:24:50 +0200 [thread overview]
Message-ID: <20170406192450.GA4195@salvia> (raw)
In-Reply-To: <20170406191819.GA3749@salvia>
On Thu, Apr 06, 2017 at 09:18:19PM +0200, Pablo Neira Ayuso wrote:
> On Mon, Mar 27, 2017 at 11:12:08PM +0800, gfree.wind@foxmail.com wrote:
> > From: Gao Feng <fgao@ikuai8.com>
> >
> > The return value type of function nf_nat_mangle_tcp/udp_packet is
> > int, but actually it is used as bool type. And most codes follow
> > this rule, for example, the sip, h323, and ftp. But some codes treat
> > the return value as NF_ACCEPT and NF_DROP, like amanda and irc.
> >
> > Now use the bool type instead of the int to make it clear.
>
> One spot still not converted.
>
> I'm going to collapse this patch to yours. Please review so you don't
> have to send a v3.
And if this chunk looks good to you, I'll apply this patch with this
title:
netfilter: nf_nat: nf_nat_mangle_{udp,tcp}_packet returns boolean
next prev parent reply other threads:[~2017-04-06 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 15:12 [PATCH nf-next v2 1/1] netfilter: nat: Correct the return value check for nat mangled packet gfree.wind
2017-04-06 19:18 ` Pablo Neira Ayuso
2017-04-06 19:24 ` Pablo Neira Ayuso [this message]
2017-04-06 22:15 ` Gao Feng
2017-04-06 22:20 ` Gao Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406192450.GA4195@salvia \
--to=pablo@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@foxmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.