All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 11/11] gst-plugins-base: fix handling of freetype
Date: Thu, 6 Apr 2017 22:46:19 +0200	[thread overview]
Message-ID: <20170406224619.65661d4e@free-electrons.com> (raw)
In-Reply-To: <20170404225019.27916-11-ricardo.martincoski@gmail.com>

Hello,

On Tue,  4 Apr 2017 19:50:19 -0300, Ricardo Martincoski wrote:
> In 2010 commit 32d319e6f "gst-plugins-base: ensure <stdint.h> is used"
> introduced a typo (missing backslash) that made the code ineffective.
> 
> It can be confirmed by looking at the output of:
> $ make printvars | grep '^GST_PLUGINS_BASE_CONF_ENV\|^FT2_CONFIG'
> FT2_CONFIG=/bin/false ac_cv_header_stdint_t="stdint.h"
> GST_PLUGINS_BASE_CONF_ENV=
> 
> Add the missing backslash to fix the code.
> While at it, fix the indentation to use one tab instead of two.
> 
> The (end of the) diff of config.log confirms the code is still needed
> when the host has freetype-config installed:
>  1704c1702
>  < configure:22348: result: make use of stdint.h in _stdint.h (assuming C99 compatible system)
>  ---
>  > configure:22348: result: make use of stdint.h in _stdint.h  
>  2499,2500c2497
>  < configure:31316: found /usr/bin/freetype-config
>  < configure:31329: result: /usr/bin/freetype-config
>  ---
>  > configure:31329: result: /bin/false  
>  2820c2817
>  < ac_cv_path_FT2_CONFIG='/usr/bin/freetype-config'
>  ---
>  > ac_cv_path_FT2_CONFIG='/bin/false'  
>  2849d2845
>  < ac_cv_stdint_result='(assuming C99 compatible system)'
>  2996,2998c2992,2994
>  < FT2_CFLAGS='-I/usr/include/freetype2'
>  < FT2_CONFIG='/usr/bin/freetype-config'
>  < FT2_LIBS='-lfreetype'
>  ---
>  > FT2_CFLAGS=''
>  > FT2_CONFIG='/bin/false'
>  > FT2_LIBS=''  

The patch looks good, but this diff format is really unreadable. Could
you regenerate it with "diff -u" so that it becomes readable?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-04-06 20:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 02/11] package: remove empty line at end of file Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 03/11] package: remove consecutive empty lines Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 04/11] package: normalize separator size to 80 Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 05/11] package: add missing empty line after header Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 06/11] package: remove trailing backslash Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 07/11] python-pylibftdi: check hash Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 08/11] python-pylibftdi: use package name for .mk file Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 09/11] tesseract-ocr: fix typo in variable name Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 10/11] gst1-plugins-base: remove legacy freetype handling Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 11/11] gst-plugins-base: fix handling of freetype Ricardo Martincoski
2017-04-06 20:46   ` Thomas Petazzoni [this message]
2017-04-11 22:59     ` [Buildroot] [PATCH v2] " Ricardo Martincoski
2017-04-12 12:41       ` Arnout Vandecappelle
2017-04-12 19:06       ` Thomas Petazzoni
2017-04-24 19:20       ` Peter Korsgaard
2017-04-06 20:45 ` [Buildroot] [PATCH 01/11] package: remove trailing whitespace Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406224619.65661d4e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.