Re: [PATCH iptables] tests: add regression tests for xtables-translate

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Mar 31, 2017 at 02:34:38PM +0200, Pablo M. Bermudo Garay wrote:
> This test suite is intended to detect regressions in the translation
> infrastructure. The script checks if ip[6]tables-translate produces the
> expected output, otherwise it prints the wrong translation and the
> expected one.
> 
> ** Arguments
> 
>   --all     # Show also passed tests
>   [test]    # Run only the specified test file
> 
> ** Test files structure
> 
> Test files are located under extensions directory. Every file contains
> tests about specific extension translations. A test file name must end
> with ".txlate".
> 
> Inside the files, every single test is defined by two consecutive lines:
> ip[6]tables-translate command and expected result. One blank line is left
> between tests by convention.
> 
> e.g.
> 
>   $ cat extensions/libxt_cpu.txlate
>   iptables-translate -A INPUT -p tcp --dport 80 -m cpu --cpu 0 -j ACCEPT
>   nft add rule ip filter INPUT tcp dport 80 cpu 0 counter accept
> 
>   iptables-translate -A INPUT -p tcp --dport 80 -m cpu ! --cpu 1 -j ACCEPT
>   nft add rule ip filter INPUT tcp dport 80 cpu != 1 counter accept

Nice... But how this works? :)

# python xlate-test.py 
Traceback (most recent call last):
  File "xlate-test.py", line 85, in <module>
    main()
  File "xlate-test.py", line 78, in main
    load_test_files()
  File "xlate-test.py", line 65, in load_test_files
    run_test(test, payload)
  File "xlate-test.py", line 43, in run_test
    output = subprocess.run(shlex.split(line), stdout=subprocess.PIPE)
AttributeError: 'module' object has no attribute 'run'