Re: [Qemu-devel] [PATCH 1/3] vhost: simple clean up

[Sahid Orentino Ferdjaoui <sferdjao@redhat.com>]

On Fri, Apr 07, 2017 at 02:58:46PM +0800, weiqi wrote:
> From: Wei Qi <weiqi4@huawei.com>
> 
> It is unnecessary to assign 'hdev->nvqs' to 'i', because 'hdev->nvqs' unused after assignment, so remove it.

nit: The line should not be longer than 76 characters [0].

[0] http://wiki.qemu-project.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message

> 
> Signed-off-by: Wei Qi <weiqi4@huawei.com>
> ---
>  hw/virtio/vhost.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-By: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>

> 
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 613494d..5c57983 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -1557,7 +1557,6 @@ fail_vq:
>                               hdev->vqs + i,
>                               hdev->vq_index + i);
>      }
> -    i = hdev->nvqs;
>  
>  fail_mem:
>  fail_features:
> -- 
> 1.8.3.1
> 
>