From: Joerg Roedel <jroedel@suse.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Drake <drake@endlessm.com>,
Alexander Deucher <Alexander.Deucher@amd.com>
Subject: Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS
Date: Fri, 7 Apr 2017 14:34:31 +0200 [thread overview]
Message-ID: <20170407123431.GC23944@suse.de> (raw)
In-Reply-To: <20170404164311.GB27692@bhelgaas-glaptop.roam.corp.google.com>
Hi Bjorn,
On Tue, Apr 04, 2017 at 11:43:11AM -0500, Bjorn Helgaas wrote:
> > +static const struct pci_device_id broken_ats_tbl[] = {
> > + { PCI_DEVICE(PCI_VENDOR_ID_AMD, 0x98e4) }, /* AMD Stoney GPU part */
Just found out that the affected GPU uses PCI_VENDOR_ID_ATI, fixed that
too.
> > + { 0 }
> > +};
> > +
> > void pci_ats_init(struct pci_dev *dev)
> >
> > int pos;
> >
> > + if (pci_match_id(broken_ats_tbl, dev))
> > + return;
>
> This is fine functionally, but from a stylistic point of view, I guess
> I would prefer to have it implemented in drivers/pci/quirks.c just to
> have some consistency in how we work around device defects.
Done, I send a new patch shortly.
Joerg
prev parent reply other threads:[~2017-04-07 12:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 12:16 [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Joerg Roedel
2017-03-28 20:18 ` Deucher, Alexander
2017-03-28 20:18 ` Deucher, Alexander
2017-03-28 20:28 ` Joerg Roedel
2017-03-28 20:37 ` Deucher, Alexander
2017-03-28 20:37 ` Deucher, Alexander
2017-03-28 20:56 ` 'Joerg Roedel'
2017-03-28 21:13 ` Deucher, Alexander
2017-03-28 21:13 ` Deucher, Alexander
2017-03-28 22:26 ` 'Joerg Roedel'
2017-03-29 7:15 ` Nath, Arindam
2017-03-29 7:15 ` Nath, Arindam
2017-03-29 9:42 ` 'Joerg Roedel'
2017-03-29 9:47 ` Nath, Arindam
2017-03-29 9:47 ` Nath, Arindam
2017-03-29 16:21 ` Deucher, Alexander
2017-03-29 16:21 ` Deucher, Alexander
2017-04-04 16:43 ` Bjorn Helgaas
2017-04-07 12:34 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407123431.GC23944@suse.de \
--to=jroedel@suse.de \
--cc=Alexander.Deucher@amd.com \
--cc=bhelgaas@google.com \
--cc=drake@endlessm.com \
--cc=helgaas@kernel.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.